You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2026/10/04 02:51:03 UTC

Re: [PR] arch/mips/pic32mz: fix the Ethernet driver and add PHY ioctls [nuttx]

xiaoxiang781216 commented on code in PR #20451:
URL: https://github.com/apache/nuttx/pull/20451#discussion_r4175888782


##########
arch/mips/src/pic32mz/pic32mz_ethernet.c:
##########
@@ -3181,11 +3182,19 @@ static inline int pic32mz_phyinit(struct pic32mz_driver_s *priv)
         (priv->pd_mode & PIC32MZ_DUPLEX_MASK) ==
           PIC32MZ_DUPLEX_FULL ?"full" : "half");
 
-  /* Disable auto-configuration.  Set the fixed speed/duplex mode.
-   * (probably more than little redundant).
+#ifdef CONFIG_PIC32MZ_PHY_AUTONEG
+  /* Keep auto-negotiation enabled so that the PHY negotiates again when
+   * the cable is reconnected.  Forcing the negotiated mode here would
+   * leave the link down against an auto-negotiating partner.
    */
 
+  ret = OK;

Review Comment:
   merge to line 2918



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org