[jira] Updated: (QPID-1524) AMQPriorityQueueTest message order is non-deterministic [AMQPriorityQueueTest causes NullPointerException]

["Martin Ritchie (JIRA)" <qp...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/QPID-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-1524:
---------------------------------

    Component/s:     (was: Java Broker)
                 Java Tests
       Priority: Minor  (was: Major)
        Summary: AMQPriorityQueueTest message order is non-deterministic [AMQPriorityQueueTest causes NullPointerException]  (was: AMQPriorityQueueTest causes NullPointerException)

Cloned this JIRA so that we can use this one to address the message ordering as it has the commit against it.
QPID-1524 will be used to address the NPE. 

> AMQPriorityQueueTest message order is non-deterministic [AMQPriorityQueueTest causes NullPointerException]
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-1524
>                 URL: https://issues.apache.org/jira/browse/QPID-1524
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Tests
>    Affects Versions: M4
>            Reporter: Martin Ritchie
>            Priority: Minor
>         Attachments: TEST-org.apache.qpid.server.queue.AMQPriorityQueueTest.txt
>
>
> Summary:
> Our CI box has failed this test twice but on looking at a clean test run we get these NPEs to standard error. I'm sure this is not good, however as we have NO logging what so ever in the message delivery path we are unable to say more on when these occured. 
> Also as this is a unit test and not a QTC we cannot tell which test caused these NPE.
> Exception in thread "pool-6-thread-1" java.lang.NullPointerException
>         at org.apache.qpid.server.queue.SimpleAMQQueue.attemptDelivery(SimpleAMQQueue.java:1254)
>         at org.apache.qpid.server.queue.SimpleAMQQueue.flushSubscription(SimpleAMQQueue.java:1216)
>         at org.apache.qpid.server.queue.SimpleAMQQueue$SubFlushRunner.run(SimpleAMQQueue.java:1177)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:619)
> Exception in thread "pool-10-thread-1" java.lang.NullPointerException
>         at org.apache.qpid.server.queue.SimpleAMQQueue.attemptDelivery(SimpleAMQQueue.java:1254)
>         at org.apache.qpid.server.queue.SimpleAMQQueue.flushSubscription(SimpleAMQQueue.java:1216)
>         at org.apache.qpid.server.queue.SimpleAMQQueue$SubFlushRunner.run(SimpleAMQQueue.java:1177)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:619)
> Test failure was:
> junit.framework.AssertionFailedError: expected:<1> but was:<6>  
> The first message was not as expected, the test does not let us know if the message was lost or simply reordered.
> Approach:
> 1) Updating the test to give more details on the loss vs. re-ordering woudl be help understand the failures
> 2) The NPEs should be resolved as this could cause other issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.