You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2025/01/14 18:26:58 UTC
[PR] [SPARK-50814][DOCS] Remove unused SQL error pages [spark]
nchammas opened a new pull request, #49486:
URL: https://github.com/apache/spark/pull/49486
### What changes were proposed in this pull request?
Remove standalone SQL error pages that were made obsolete by the work completed in #44971.
Also fix the formatting of the error message for `QUERY_ONLY_CORRUPT_RECORD_COLUMN`, since it was incorrect and overflowing the table cell it belongs to.
### Why are the changes needed?
These error pages are either already captured completely in `common/utils/src/main/resources/error/error-conditions.json`, or are obsolete and not needed (and are not being rendered in the documentation output anyway).
The formatting of `QUERY_ONLY_CORRUPT_RECORD_COLUMN` before and after:
<img src="https://github.com/user-attachments/assets/476c57e0-dfa5-403e-8a7d-2d05301eb7a3" width=650 />
<img src="https://github.com/user-attachments/assets/106d5bca-6569-488c-9b9c-1a27345fc7a8" width=450 />
### Does this PR introduce _any_ user-facing change?
Yes, documentation formatting.
### How was this patch tested?
Built the docs locally and reviewed them in my browser.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50814][DOCS] Remove unused SQL error pages [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #49486: [SPARK-50814][DOCS] Remove unused SQL error pages
URL: https://github.com/apache/spark/pull/49486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50814][DOCS] Remove unused SQL error pages [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #49486:
URL: https://github.com/apache/spark/pull/49486#issuecomment-2591078125
cc @MaxGekk as I believe you have recently reviewed similar doc PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50814][DOCS] Remove unused SQL error pages [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49486:
URL: https://github.com/apache/spark/pull/49486#issuecomment-2591862781
+1, LGTM. Merging to master.
Thank you, @nchammas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org