You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Benjamin Bentmann <be...@udo.edu> on 2009/05/02 10:31:34 UTC
Re: svn commit: r770824 - /maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
Hi Paul,
> Author: pgier
> Date: Fri May 1 21:23:20 2009
> New Revision: 770824
>
> URL: http://svn.apache.org/viewvc?rev=770824&view=rev
> Log:
> Add some info to the ant tests.
>
> Modified:
> maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
>
> Modified: maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
> URL: http://svn.apache.org/viewvc/maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml?rev=770824&r1=770823&r2=770824&view=diff
> ==============================================================================
> --- maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml (original)
> +++ maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml Fri May 1 21:23:20 2009
> @@ -402,7 +413,7 @@
> <echo file="target/test file.txt">dummy</echo>
> <artifact:deploy file="target/test file.txt">
> <!-- intentionnally left without id to check default id: see MANTTASKS-103 -->
> - <remoteRepository url="scp://localhost/tmp/deployment-repo"/>
> + <remoteRepository url="scp://localhost/tmp/deployment-repo" id="scp.localhost.repo"/>
This added an explicit repo id which seems to invalidate the test as per
the XML comment above it, isn't it?
Benjamin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r770824 - /maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
Posted by Paul Gier <pg...@redhat.com>.
Thanks for fixing it. I put the id in there while trying to set it up to
automatically use my user/password in settings.xml, and forgot to take it out.
Hervé BOUTEMY wrote:
> I missed this one: thank you for pointing that
>
> BTW, this reminded me MANTTASKS-103, where I fixed what you reported in
> MANTTASKS-142: can you check I didn't miss anything, and close the issue if
> everything is ok?
>
> Regards,
>
> Hervé
>
> Le samedi 02 mai 2009, Benjamin Bentmann a écrit :
>> Hi Paul,
>>
>>> Author: pgier
>>> Date: Fri May 1 21:23:20 2009
>>> New Revision: 770824
>>>
>>> URL: http://svn.apache.org/viewvc?rev=770824&view=rev
>>> Log:
>>> Add some info to the ant tests.
>>>
>>> Modified:
>>> maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
>>>
>>> Modified: maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
>>> URL:
>>> http://svn.apache.org/viewvc/maven/ant-tasks/branches/maven-ant-tasks-2.0
>>> .x/sample.build.xml?rev=770824&r1=770823&r2=770824&view=diff
>>> =========================================================================
>>> ===== --- maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
>>> (original) +++
>>> maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml Fri May
>>> 1 21:23:20 2009 @@ -402,7 +413,7 @@
>>> <echo file="target/test file.txt">dummy</echo>
>>> <artifact:deploy file="target/test file.txt">
>>> <!-- intentionnally left without id to check default id: see
>>> MANTTASKS-103 --> - <remoteRepository
>>> url="scp://localhost/tmp/deployment-repo"/> + <remoteRepository
>>> url="scp://localhost/tmp/deployment-repo" id="scp.localhost.repo"/>
>> This added an explicit repo id which seems to invalidate the test as per
>> the XML comment above it, isn't it?
>>
>>
>> Benjamin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r770824 - /maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
Posted by Hervé BOUTEMY <he...@free.fr>.
I missed this one: thank you for pointing that
BTW, this reminded me MANTTASKS-103, where I fixed what you reported in
MANTTASKS-142: can you check I didn't miss anything, and close the issue if
everything is ok?
Regards,
Hervé
Le samedi 02 mai 2009, Benjamin Bentmann a écrit :
> Hi Paul,
>
> > Author: pgier
> > Date: Fri May 1 21:23:20 2009
> > New Revision: 770824
> >
> > URL: http://svn.apache.org/viewvc?rev=770824&view=rev
> > Log:
> > Add some info to the ant tests.
> >
> > Modified:
> > maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
> >
> > Modified: maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
> > URL:
> > http://svn.apache.org/viewvc/maven/ant-tasks/branches/maven-ant-tasks-2.0
> >.x/sample.build.xml?rev=770824&r1=770823&r2=770824&view=diff
> > =========================================================================
> >===== --- maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml
> > (original) +++
> > maven/ant-tasks/branches/maven-ant-tasks-2.0.x/sample.build.xml Fri May
> > 1 21:23:20 2009 @@ -402,7 +413,7 @@
> > <echo file="target/test file.txt">dummy</echo>
> > <artifact:deploy file="target/test file.txt">
> > <!-- intentionnally left without id to check default id: see
> > MANTTASKS-103 --> - <remoteRepository
> > url="scp://localhost/tmp/deployment-repo"/> + <remoteRepository
> > url="scp://localhost/tmp/deployment-repo" id="scp.localhost.repo"/>
>
> This added an explicit repo id which seems to invalidate the test as per
> the XML comment above it, isn't it?
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org