You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2019/11/26 20:54:00 UTC

[jira] [Comment Edited] (FELIX-6204) org.apache.felix.scrplugin.helper.ClassScanner.scanSources should ignore module-info

    [ https://issues.apache.org/jira/browse/FELIX-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982860#comment-16982860 ] 

Julian Reschke edited comment on FELIX-6204 at 11/26/19 8:53 PM:
-----------------------------------------------------------------

This:

{noformat}
diff --git a/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java b/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
index 954bffe51..b022426ee 100644
--- a/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
+++ b/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
@@ -137,8 +137,12 @@ public class ClassScanner {
                 log.debug("Skipping file " + src.getClassName());
                 continue;
             }
-            log.debug("Scanning class " + src.getClassName());
+            if ( src.getClassName().equals("module-info") ) {
+                log.debug("Skipping file " + src.getClassName());
+                continue;
+            }

+            log.debug("Scanning class " + src.getClassName());
             try {
                 // load the class
                 final Class<?> annotatedClass = project.getClassLoader().loadClass(src.getClassName());
{noformat}

works for me.


was (Author: reschke):
This:

{noformat}
diff --git a/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java b/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
index 954bffe51..b022426ee 100644
--- a/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
+++ b/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/helper/ClassScanner.java
@@ -137,8 +137,12 @@ public class ClassScanner {
                 log.debug("Skipping file " + src.getClassName());
                 continue;
             }
-            log.debug("Scanning class " + src.getClassName());
+            if ( src.getClassName().equals("module-info") ) {
+                log.debug("Skipping file " + src.getClassName());
+                continue;
+            }

+            log.debug("Scanning class " + src.getClassName());
             try {
                 // load the class
                 final Class<?> annotatedClass = project.getClassLoader().loadClass(src.getClassName());
{noformat]

works for me.

> org.apache.felix.scrplugin.helper.ClassScanner.scanSources should ignore module-info
> ------------------------------------------------------------------------------------
>
>                 Key: FELIX-6204
>                 URL: https://issues.apache.org/jira/browse/FELIX-6204
>             Project: Felix
>          Issue Type: Bug
>          Components: SCR Tooling
>    Affects Versions: scr bnd plugin 1.9.4
>            Reporter: Julian Reschke
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)