You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CodingSinger (GitHub)" <gi...@apache.org> on 2020/03/20 07:17:01 UTC

[GitHub] [dubbo-go] CodingSinger opened pull request #432: Bug fix

1. modify registryProtocol as a singleton to fix graceful shutdown can't delete the provider url
2. fix notification confusion caused by multiple references sharing the same zk listener




[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the comment, pls.

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] pantianying commented on pull request #432: Fix: issue #32

Posted by "pantianying (GitHub)" <gi...@apache.org>.
is there Concurrency problem？

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls close the listener outside of the lock scope.

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #432: Fix: issue #32

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=h1) Report
> Merging [#432](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/805ffd678d16f9270c85650421ed0fb1bb0676d2?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `51.06%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/432/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #432      +/-   ##
===========================================
- Coverage    67.09%   67.01%   -0.08%     
===========================================
  Files          177      177              
  Lines         9359     9381      +22     
===========================================
+ Hits          6279     6287       +8     
- Misses        2462     2475      +13     
- Partials       618      619       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.36% <0%> (-0.38%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `49.52% <31.81%> (-5.48%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <80.95%> (+1.28%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0%> (-0.94%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `71.42% <0%> (+0.27%)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `73.52% <0%> (+0.39%)` | :arrow_up: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0%> (+1.21%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=footer). Last update [805ffd6...5281622](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
@CodingSinger pls do not use pointer as map key.

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
add comment

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
> why？ I see the golang spec includes a pointer-keyed map as an example.

show me the link.

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #432: Fix: issue #32

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=h1) Report
> Merging [#432](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `70.96%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/432/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   67.41%   67.28%   -0.13%     
==========================================
  Files         174      174              
  Lines        9261     9266       +5     
==========================================
- Hits         6243     6235       -8     
- Misses       2416     2424       +8     
- Partials      602      607       +5     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.36% <0.00%> (-0.38%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `66.66% <80.95%> (+1.28%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `54.94% <83.33%> (-0.51%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `59.81% <0.00%> (-5.61%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.24% <0.00%> (-1.89%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0.00%> (-0.66%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=footer). Last update [bde7db3...19aa34e](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #432: Bug fix

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=h1) Report
> Merging [#432](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `88.88%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/432/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   67.41%   67.26%   -0.15%     
==========================================
  Files         174      174              
  Lines        9261     9253       -8     
==========================================
- Hits         6243     6224      -19     
- Misses       2416     2423       +7     
- Partials      602      606       +4     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `82.48% <0.00%> (+0.75%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `54.94% <83.33%> (-0.51%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `67.85% <100.00%> (+2.47%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-8.42%)` | :arrow_down: |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (-3.39%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-2.84%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0.00%> (-0.66%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (+9.37%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=footer). Last update [bde7db3...0b268af](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #432: Fix: issue #32

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=h1) Report
> Merging [#432](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/bde7db3b33067ee4115ea3f8666ec1169226a5de&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `76.19%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/432/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   67.41%   67.37%   -0.04%     
==========================================
  Files         174      174              
  Lines        9261     9256       -5     
==========================================
- Hits         6243     6236       -7     
  Misses       2416     2416              
- Partials      602      604       +2     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.36% <0.00%> (-0.38%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `54.94% <83.33%> (-0.51%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `67.85% <100.00%> (+2.47%)` | :arrow_up: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-2.84%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `62.61% <0.00%> (-2.81%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `58.36% <0.00%> (-0.66%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/432/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (+9.37%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=footer). Last update [bde7db3...a6130ef](https://codecov.io/gh/apache/dubbo-go/pull/432?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on pull request #432: Fix: issue #32

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
I think so , dubbo-check or lock or once?

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #432: Fix: issue #32

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
change the comment.

[ Full content available at: https://github.com/apache/dubbo-go/pull/432 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org