You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by mi...@apache.org on 2006/06/21 14:37:09 UTC

svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Author: michi
Date: Wed Jun 21 05:37:09 2006
New Revision: 415977

URL: http://svn.apache.org/viewvc?rev=415977&view=rev
Log:
neutron does differentiate between save and checkin

Modified:
    lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Modified: lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl
URL: http://svn.apache.org/viewvc/lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl?rev=415977&r1=415976&r2=415977&view=diff
==============================================================================
--- lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl (original)
+++ lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl Wed Jun 21 05:37:09 2006
@@ -32,14 +32,11 @@
   <introspection>
     <edit mime-type="application/xml" name="Body Content">
 
-      <!-- TODO: Re-use existing or create new lenya.usecase for opening and saving ... -->
       <open url="{$context}/{$publication}/authoring/{$page-id}.xml" method="GET"/>
-      <save url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" method="PUT"/>
 
       <checkout url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkout" method="GET"/>
-      <checkin  url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin"  method="PUT"/>
-
 
+      <save url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" method="PUT"/>
 
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Andreas Hartmann <an...@apache.org>.
Jörn Nettingsmeier wrote:
> Michael Wechner wrote:
>> ok, let me try to put it into a module. I guess it won't hurt even if
>> one might consider
>> it a core functionality.
> 
> yeah, i think making something a module does not imply that it's not
> core functionality. ultimately, everything should be a module. that is
> the only way to clean up the insanely complicated sitemaps in lenya
> imho, and although it will be hard in some cases, it would improve
> maintainability and ease the learning curve for new users a lot.

Big +1

> i'd even suggest that no new features apart from generic infrastructure
> are accepted into the tree if they are not modularized.

When the core is split up into modules, the only question is which
module a new function belongs to or if it needs a separate module.

-- Andreas

> 
> *.*
> 
> sorry to be a nuisance about this, but could somebody be bothered to
> explain to old stupid me what introspection is and what i can use it
> for? i've read all prior mails on this subject, googled, and i still
> have no idea.
> 
> (btw, another great feature of modules is that they are contained in a
> sub-directory of their own, which in turn lends itself well to housing a
> file named "README" ;)


-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
andreas.hartmann@wyona.com                     andreas@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Michael Wechner <mi...@wyona.com>.
Jörn Nettingsmeier wrote:
>
> sorry to be a nuisance about this, but could somebody be bothered to
> explain to old stupid me what introspection is and what i can use it
> for?

http://demo.phoenix.wyona.org

http://www.wyona.org/osr-101/osr-101.xhtml#introspection

>  i've read all prior mails on this subject, googled, and i still
> have no idea.
>
> (btw, another great feature of modules is that they are contained in a
> sub-directory of their own, which in turn lends itself well to housing a
> file named "README" ;)
>   

the README should go into the "module.xml" ;-)

Michi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>
>   


-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner@wyona.com                        michi@apache.org
+41 44 272 91 61


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Jörn Nettingsmeier <po...@uni-duisburg.de>.
Michael Wechner wrote:
> ok, let me try to put it into a module. I guess it won't hurt even if
> one might consider
> it a core functionality.

yeah, i think making something a module does not imply that it's not
core functionality. ultimately, everything should be a module. that is
the only way to clean up the insanely complicated sitemaps in lenya
imho, and although it will be hard in some cases, it would improve
maintainability and ease the learning curve for new users a lot.

i'd even suggest that no new features apart from generic infrastructure
are accepted into the tree if they are not modularized.

*.*

sorry to be a nuisance about this, but could somebody be bothered to
explain to old stupid me what introspection is and what i can use it
for? i've read all prior mails on this subject, googled, and i still
have no idea.

(btw, another great feature of modules is that they are contained in a
sub-directory of their own, which in turn lends itself well to housing a
file named "README" ;)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Andreas Hartmann <an...@apache.org>.
Michael Wechner wrote:
> Andreas Hartmann wrote:
>> Michael Wechner wrote:
>>
>> [...]
>>
>>>>> -      <save 
>>>>> url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" 
>>>>> method="PUT"/>
>>>>
>>>> that looks very specific to me.
>>>
>>> what do you mean by specific?
>>
>> Specific to a certain functionality which is beyond the basic
>> scope of a CMS (of course this depends on the point of view,
>> this is just my own perception).
> don't you think introspection is  a very generic feature?

 From my point of view, the question is not if it is generic, but
rather if it can be isolated from other parts of the core.

The primary goal should be modularization and isolation to improve
understandability and maintainability and to enforce SoC and loose
coupling. Only if some components are very interdependent and can'
be decoupled, they should be put in the same module.

Modularization is IMO orthogonal to the separation between core and
"add-ons". The core can be modularized in the same way as add-on
functionality.

[...]

>> It works the same way as in the core. You can address all module 
>> resources
>> using the cocoon:// protocol and http://localhost:8888/modules/... URLs.
> 
> ok, let me try to put it into a module. I guess it won't hurt even if 
> one might conside it a core functionality.

I totally agree :)

-- Andreas


-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
andreas.hartmann@wyona.com                     andreas@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Michael Wechner <mi...@wyona.com>.
Andreas Hartmann wrote:
> Michael Wechner wrote:
>
> [...]
>
>>>> -      <save 
>>>> url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" 
>>>> method="PUT"/>
>>>
>>> that looks very specific to me.
>>
>> what do you mean by specific?
>
> Specific to a certain functionality which is beyond the basic
> scope of a CMS (of course this depends on the point of view,
> this is just my own perception).
don't you think introspection is  a very generic feature?

Of course there are different kinds of introspection, e.g. APP, Neutron, ...
>
>
>> I think introspection should be a core functionality,  but yes the 
>> ".xml" is rather specific
>> and I am currently testing it with the default publication, whereas I 
>> think it should work with any resource type in the future.
>>> Wouldn't it make sense to put the neutron/introspection code in a 
>>> module
>>> instead of the core?
>>
>> as said I think introspection should be a core functionality, but the 
>> reason I put it there and also the neutron usecase is
>> because BXE and Kupu are also there, but that of course isn't a good 
>> argument ;-)
>
> BXE has its own module (there was an empty directory in lenya/usecases
> which I removed now).

ok
> IMO Kupu should be moved to a module as well, but unfortunately I'm not
> familiar with the Kupu integration code and I didn't yet find the time
> to move it.
>
>
>> How can I make the neutron usecase accessible when I move it into a 
>> module?
>
> It works the same way as in the core. You can address all module 
> resources
> using the cocoon:// protocol and http://localhost:8888/modules/... URLs.

ok, let me try to put it into a module. I guess it won't hurt even if 
one might consider
it a core functionality.

Michi
>
> -- Andreas
>


-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner@wyona.com                        michi@apache.org
+41 44 272 91 61


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Andreas Hartmann <an...@apache.org>.
Michael Wechner wrote:

[...]

>>> -      <save 
>>> url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" 
>>> method="PUT"/>
>>
>> that looks very specific to me.
> 
> what do you mean by specific?

Specific to a certain functionality which is beyond the basic
scope of a CMS (of course this depends on the point of view,
this is just my own perception).


> I think introspection should be a core 
> functionality,  but yes the ".xml" is rather specific
> and I am currently testing it with the default publication, whereas I 
> think it should work with any resource type in the future.
>> Wouldn't it make sense to put the neutron/introspection code in a module
>> instead of the core?
> 
> as said I think introspection should be a core functionality, but the 
> reason I put it there and also the neutron usecase is
> because BXE and Kupu are also there, but that of course isn't a good 
> argument ;-)

BXE has its own module (there was an empty directory in lenya/usecases
which I removed now).
IMO Kupu should be moved to a module as well, but unfortunately I'm not
familiar with the Kupu integration code and I didn't yet find the time
to move it.


> How can I make the neutron usecase accessible when I move it into a module?

It works the same way as in the core. You can address all module resources
using the cocoon:// protocol and http://localhost:8888/modules/... URLs.

-- Andreas

-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
andreas.hartmann@wyona.com                     andreas@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Michael Wechner <mi...@wyona.com>.
Andreas Hartmann wrote:
> Hi Michi,
>
> michi@apache.org wrote:
>> Author: michi
>> Date: Wed Jun 21 05:37:09 2006
>> New Revision: 415977
>>
>> URL: http://svn.apache.org/viewvc?rev=415977&view=rev
>> Log:
>> neutron does differentiate between save and checkin
>>
>> Modified:
>>     lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl
>>
>> Modified: lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl
>> URL: 
>> http://svn.apache.org/viewvc/lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl?rev=415977&r1=415976&r2=415977&view=diff 
>>
>> ============================================================================== 
>>
>> --- lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl (original)
>> +++ lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl Wed Jun 
>> 21 05:37:09 2006
>> @@ -32,14 +32,11 @@
>>    <introspection>
>>      <edit mime-type="application/xml" name="Body Content">
>>  
>> -      <!-- TODO: Re-use existing or create new lenya.usecase for 
>> opening and saving ... -->
>>        <open url="{$context}/{$publication}/authoring/{$page-id}.xml" 
>> method="GET"/>
>> -      <save 
>> url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" 
>> method="PUT"/>
>
> that looks very specific to me.

what do you mean by specific? I think introspection should be a core 
functionality, but yes the ".xml" is rather specific
and I am currently testing it with the default publication, whereas I 
think it should work with any resource type in the future.
> Wouldn't it make sense to put the neutron/introspection code in a module
> instead of the core?

as said I think introspection should be a core functionality, but the 
reason I put it there and also the neutron usecase is
because BXE and Kupu are also there, but that of course isn't a good 
argument ;-)

How can I make the neutron usecase accessible when I move it into a module?

Thanks

Michi
>
> -- Andreas
>
>


-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner@wyona.com                        michi@apache.org
+41 44 272 91 61


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: svn commit: r415977 - /lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl

Posted by Andreas Hartmann <an...@apache.org>.
Hi Michi,

michi@apache.org wrote:
> Author: michi
> Date: Wed Jun 21 05:37:09 2006
> New Revision: 415977
> 
> URL: http://svn.apache.org/viewvc?rev=415977&view=rev
> Log:
> neutron does differentiate between save and checkin
> 
> Modified:
>     lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl
> 
> Modified: lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl?rev=415977&r1=415976&r2=415977&view=diff
> ==============================================================================
> --- lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl (original)
> +++ lenya/trunk/src/webapp/lenya/xslt/util/introspection.xsl Wed Jun 21 05:37:09 2006
> @@ -32,14 +32,11 @@
>    <introspection>
>      <edit mime-type="application/xml" name="Body Content">
>  
> -      <!-- TODO: Re-use existing or create new lenya.usecase for opening and saving ... -->
>        <open url="{$context}/{$publication}/authoring/{$page-id}.xml" method="GET"/>
> -      <save url="{$context}/{$publication}/authoring/{$page-id}.xml?lenya.usecase=neutron&amp;lenya.step=checkin" method="PUT"/>

that looks very specific to me.
Wouldn't it make sense to put the neutron/introspection code in a module
instead of the core?

-- Andreas


-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
andreas.hartmann@wyona.com                     andreas@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org