You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhaojinchao95 (via GitHub)" <gi...@apache.org> on 2023/02/10 08:54:51 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #24105: Refactor db-discovery it use awaitility framework replace sleep
zhaojinchao95 opened a new pull request, #24105:
URL: https://github.com/apache/shardingsphere/pull/24105
Fixes #ISSUSE_ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #24105: Refactor db-discovery it use awaitility framework replace sleep
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on code in PR #24105:
URL: https://github.com/apache/shardingsphere/pull/24105#discussion_r1102777144
##########
test/e2e/discovery/src/test/java/org/apache/shardingsphere/test/e2e/discovery/build/DiscoveryRuleBuilder.java:
##########
@@ -17,17 +17,18 @@
package org.apache.shardingsphere.test.e2e.discovery.build;
-import org.apache.shardingsphere.data.pipeline.core.util.ThreadUtil;
import org.apache.shardingsphere.test.e2e.discovery.cases.base.BaseDiscoveryE2EIT;
import org.apache.shardingsphere.test.e2e.discovery.command.DiscoveryDistSQLCommand;
+import org.testcontainers.shaded.org.awaitility.Awaitility;
+import org.testcontainers.shaded.org.awaitility.Durations;
Review Comment:
Remember to correct the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #24105: Refactor db-discovery it use awaitility framework replace sleep
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24105:
URL: https://github.com/apache/shardingsphere/pull/24105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on a diff in pull request #24105: Refactor db-discovery it use awaitility framework replace sleep
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on code in PR #24105:
URL: https://github.com/apache/shardingsphere/pull/24105#discussion_r1102780392
##########
test/e2e/discovery/src/test/java/org/apache/shardingsphere/test/e2e/discovery/build/DiscoveryRuleBuilder.java:
##########
@@ -17,17 +17,18 @@
package org.apache.shardingsphere.test.e2e.discovery.build;
-import org.apache.shardingsphere.data.pipeline.core.util.ThreadUtil;
import org.apache.shardingsphere.test.e2e.discovery.cases.base.BaseDiscoveryE2EIT;
import org.apache.shardingsphere.test.e2e.discovery.command.DiscoveryDistSQLCommand;
+import org.testcontainers.shaded.org.awaitility.Awaitility;
+import org.testcontainers.shaded.org.awaitility.Durations;
Review Comment:
Thanks,i will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org