You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/27 05:32:27 UTC
[GitHub] [incubator-inlong] Greedyu opened a new pull request #2769: [INLONG-2759][Manager] Fix InlongGroup object modification exception
Greedyu opened a new pull request #2769:
URL: https://github.com/apache/incubator-inlong/pull/2769
### Title Name: [INLONG-2759][Manager] Fix InlongGroup object modification exception
Fixes #2759
First of all, the reason is that the GroupState.forCode() function has passed a null value. The reason is that the request object InlongGroupRequest does not add the annotation @ApiModelProperty() to the status field.
Originally, an annotation was added to the status field, but the reviewer believes that the status should not be set in the request, and there may be abnormal status flow caused by front-end parameters. We should handle state in the backend system.
<img width="852" alt="image" src="https://user-images.githubusercontent.com/20356765/155869469-6fbbb136-5e04-4f5e-82c1-b3781eb68128.png">
Then continue to use the postman tool to form the status parameter for testing. A new problem has arisen: Current state=wait_submit is not allowed to transfer to state=wait_submit
This is because there is no conversion from GROUP_WAIT_SUBMIT to GROUP_WAIT_SUBMIT in the status transition. The above scenario should be missed here, so I fixed it and tested it again through the post. Finally verified successfully
The state needs to be controlled in the interface, and the background business logic is required later here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] Greedyu commented on pull request #2769: [INLONG-2759][Manager] Fix InlongGroup object modification exception
Posted by GitBox <gi...@apache.org>.
Greedyu commented on pull request #2769:
URL: https://github.com/apache/incubator-inlong/pull/2769#issuecomment-1058974712
has been fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a change in pull request #2769: [INLONG-2759][Manager] Fix InlongGroup object modification exception
Posted by GitBox <gi...@apache.org>.
kipshi commented on a change in pull request #2769:
URL: https://github.com/apache/incubator-inlong/pull/2769#discussion_r818340605
##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/GroupState.java
##########
@@ -46,7 +46,7 @@
GROUP_FINITE_STATE_AUTOMATON.put(GROUP_DRAFT,
Sets.newHashSet(GROUP_WAIT_SUBMIT, GROUP_DELETE));
GROUP_FINITE_STATE_AUTOMATON.put(GROUP_WAIT_SUBMIT,
- Sets.newHashSet(GROUP_WAIT_APPROVAL, GROUP_DELETE));
+ Sets.newHashSet(GROUP_WAIT_SUBMIT, GROUP_WAIT_APPROVAL, GROUP_DELETE));
Review comment:
this has been fixed in master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] Greedyu closed pull request #2769: [INLONG-2759][Manager] Fix InlongGroup object modification exception
Posted by GitBox <gi...@apache.org>.
Greedyu closed pull request #2769:
URL: https://github.com/apache/incubator-inlong/pull/2769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org