You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by janakact <gi...@git.apache.org> on 2016/05/08 07:15:47 UTC
[GitHub] tajo pull request: Added General Index for Maria DB
GitHub user janakact opened a pull request:
https://github.com/apache/tajo/pull/1012
Added General Index for Maria DB
Added General Index : Consists of DB_ID and TID and COLUMN_NAMES
Issue: https://issues.apache.org/jira/browse/TAJO-2117
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janakact/tajo TAJO-2117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/1012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1012
----
commit 60d583a9fe33f1247120b947fe923251a9ae5598
Author: Janaka <ja...@users.noreply.github.com>
Date: 2016-05-07T09:43:14Z
Added General Index (DB_ID, TID and COLUMN_NAMES)
Added General Index : Consists of DB_ID and TID and COLUMN_NAMES
Issue: https://issues.apache.org/jira/browse/TAJO-2117
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2117: Add some missing index to MariaDBSto...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/1012#issuecomment-218040583
+1
Congrats for your first contribution. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2117: Add some missing index to MariaDBSto...
Posted by janakact <gi...@git.apache.org>.
Github user janakact commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1012#discussion_r62434069
--- Diff: tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml ---
@@ -19,6 +19,7 @@
<tns:store xmlns:tns="http://tajo.apache.org/catalogstore" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tajo.apache.org/catalogstore ../DBMSSchemaDefinition.xsd ">
<!--
Catalog base version history
+ * 13 - 2016-05-07: Added general index consist of DB_ID, TID, COLUMN_NAMES (TAJO-2117)
--- End diff --
I changed the title to origin JIRA issue title. Hope it will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2117: Add some missing index to MariaDBSto...
Posted by janakact <gi...@git.apache.org>.
Github user janakact commented on the pull request:
https://github.com/apache/tajo/pull/1012#issuecomment-217729519
Hi @blrunner,
Thanks for you help. Hope this will work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Added General Index for Maria DB
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1012#discussion_r62433574
--- Diff: tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mariadb/mariadb.xml ---
@@ -19,6 +19,7 @@
<tns:store xmlns:tns="http://tajo.apache.org/catalogstore" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tajo.apache.org/catalogstore ../DBMSSchemaDefinition.xsd ">
<!--
Catalog base version history
+ * 13 - 2016-05-07: Added general index consist of DB_ID, TID, COLUMN_NAMES (TAJO-2117)
--- End diff --
You need to use the title of origin JIRA issue. If you want to write other comments to above history, you should rename the title of JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Added General Index for Maria DB
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/1012#issuecomment-217726860
Hi @janakact ,
Thanks for your contribution.
Check my trivial comments. After testing with MariaDB server, I'll prepare to commit your patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2117: Add some missing index to MariaDBSto...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---