[GitHub] [spark] srowen commented on pull request #34313: [SPARK-37013][SQL] Ensure `format_string` has same behavior when using Java 8 and Java 17

[GitBox <gi...@apache.org>]

srowen commented on pull request #34313:
URL: https://github.com/apache/spark/pull/34313#issuecomment-946876750


   I'm kinda confused - seems like using index 0 was always disallowed: https://docs.oracle.com/javase/8/docs/api/java/util/Formatter.html
   "The first argument is referenced by "1$", the second by "2$", etc."
   
   I wonder how it ever worked or what it did? If it was illegal to begin with, we could just let Java 17 enforce it. I'm OK with explicitly enforcing it in order to avoid behavior difference across JVMs for the same Spark version too. I would not edit the format string, I think.
   
   Wouldn't all the numbered indices have to change anyway? otherwise editing the string might result in two arguments at position 1. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org