You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by chenliang613 <gi...@git.apache.org> on 2017/12/01 14:12:30 UTC

[GitHub] carbondata pull request #1575: [CARBONDATA-1698]Adding support for table lev...

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1575#discussion_r154353706
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
    @@ -863,6 +863,16 @@
       public static final String TABLE_BLOCKSIZE = "table_blocksize";
       // set in column level to disable inverted index
       public static final String NO_INVERTED_INDEX = "no_inverted_index";
    +  // table property name of major compaction size
    +  public static final String TBL_PROP_MAJOR_COMPACTION_SIZE = "major_compaction_size";
    --- End diff --
    
    suggest keeping the consistent name format , how about MAJOR_COMPACTION_SIZE,  remove "TBL_PROP"


---