You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Clark (JIRA)" <ji...@apache.org> on 2008/06/20 00:47:44 UTC

[jira] Created: (THRIFT-44) Python tests don't pass

Python tests don't pass
-----------------------

                 Key: THRIFT-44
                 URL: https://issues.apache.org/jira/browse/THRIFT-44
             Project: Thrift
          Issue Type: Bug
          Components: Library (Python)
            Reporter: Kevin Clark


This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606601#action_12606601 ] 

dreiss edited comment on THRIFT-44 at 6/19/08 4:48 PM:
------------------------------------------------------------

That would work.  We could also just modify the test to use
try:
..try;
....risky
..except Something:
....handle
finally:
..cleanup

      was (Author: dreiss):
    That would work.  We could also just modify the test to use
{{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup
}}}
  
> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607745#action_12607745 ] 

David Reiss commented on THRIFT-44:
-----------------------------------

LGTM.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt, syntax_error_in_python_24.diff
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-44) Python tests don't pass

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark updated THRIFT-44:
------------------------------

    Attachment: syntax_error_in_python_24.diff

This patch fixes the syntax error. A pythonista should review.

This makes the python make check pass, but now I'm getting something like 1600 failures in the cpp make check. I'll add another ticket as soon as this one is pushed in.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt, syntax_error_in_python_24.diff
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606601#action_12606601 ] 

dreiss edited comment on THRIFT-44 at 6/19/08 4:47 PM:
------------------------------------------------------------

That would work.  We could also just modify the test to use
{{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup
}}}

      was (Author: dreiss):
    That would work.  We could also just modify the test to use
{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup
}}
  
> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-44) Python tests don't pass

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606600#action_12606600 ] 

Kevin Clark commented on THRIFT-44:
-----------------------------------

So the fix is a mod to configure.ac to look for Python 2.5 rather than 2.4, yes?

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-44) Python tests don't pass

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark updated THRIFT-44:
------------------------------

    Patch Info: [Patch Available]

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt, syntax_error_in_python_24.diff
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606601#action_12606601 ] 

dreiss edited comment on THRIFT-44 at 6/19/08 4:47 PM:
------------------------------------------------------------

That would work.  We could also just modify the test to use
{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup
}}

      was (Author: dreiss):
    That would work.  We could also just modify the test to use
{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup
  
> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-44:
------------------------------

    Component/s:     (was: Library (Python))
                 Test Suite

Try running make first.  I'm pretty sure this is a problem with the test suite, rather than Thrift/Python itself.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606601#action_12606601 ] 

David Reiss commented on THRIFT-44:
-----------------------------------

That would work.  We could also just modify the test to use
{{
try:
  try;
    risky
  except Something:
    handle
finally:
  cleanup

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-44) Python tests don't pass

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark updated THRIFT-44:
------------------------------

    Attachment: make_check_failure.txt

Here's the output, including a make run pre-make check. Appears to be a syntax error.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-44) Python tests don't pass

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606599#action_12606599 ] 

David Reiss commented on THRIFT-44:
-----------------------------------

"""Changed in version 2.5: In previous versions of Python, try...except...finally did not work. try...except had to be nested in try...finally."""

Looks like we do depend on Python 2.5 after all.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-44) Python tests don't pass

Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Clark closed THRIFT-44.
-----------------------------

    Resolution: Fixed

Pushed in 671337.

> Python tests don't pass
> -----------------------
>
>                 Key: THRIFT-44
>                 URL: https://issues.apache.org/jira/browse/THRIFT-44
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>            Reporter: Kevin Clark
>         Attachments: make_check_failure.txt, syntax_error_in_python_24.diff
>
>
> This makes `make check` not pass. It should.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.