You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jrushford <gi...@git.apache.org> on 2016/09/13 21:11:02 UTC
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
GitHub user jrushford opened a pull request:
https://github.com/apache/trafficserver/pull/1015
TS-4845: NULL dereference in url_sig
Fix a NULL dereference in url_sig.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jrushford/trafficserver TS-4845
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1015.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1015
----
commit 6b4100c1200e309e229c9fdd24004e1d4fb59c9a
Author: John J. Rushford <jr...@apache.org>
Date: 2016-09-13T21:08:52Z
TS-4845: NULL dereference in url_sig
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford closed the pull request at:
https://github.com/apache/trafficserver/pull/1015
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1015
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/695/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1015#discussion_r78650646
--- Diff: plugins/experimental/url_sig/url_sig.c ---
@@ -561,7 +561,9 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo *rri)
/* ********* Allow ********* */
allow:
- app_qry = getAppQueryString(query, strlen(query));
+ if (query != NULL) {
+ app_qry = getAppQueryString(query, strlen(query));
+ }
--- End diff --
So this is the case where the exclusion regex was matched so it is ok to not have a query string?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1015
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/799/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1015
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/800/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1015
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/694/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1015
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1015: TS-4845: NULL dereference in url_sig
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1015#discussion_r78652614
--- Diff: plugins/experimental/url_sig/url_sig.c ---
@@ -561,7 +561,9 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp, TSRemapRequestInfo *rri)
/* ********* Allow ********* */
allow:
- app_qry = getAppQueryString(query, strlen(query));
+ if (query != NULL) {
+ app_qry = getAppQueryString(query, strlen(query));
+ }
--- End diff --
Yes, thanks for the catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1015: TS-4845: NULL dereference in url_sig
Posted by jrushford <gi...@git.apache.org>.
Github user jrushford commented on the issue:
https://github.com/apache/trafficserver/pull/1015
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---