You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Apache Continuum <de...@continuum.apache.org> on 2014/07/16 14:47:21 UTC

[continuum] BUILD FAILURE: Apache Commons DBCP - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=34135&projectId=73

Build statistics:
  State: Failed
  Previous State: Ok
  Started at: Wed 16 Jul 2014 12:47:05 +0000
  Finished at: Wed 16 Jul 2014 12:47:17 +0000
  Total time: 12s
  Build Trigger: Forced
  Build Number: 270
  Exit code: 1
  Building machine hostname: continuum-vm
  Operating system : Linux(unknown)
  Java Home version : 
          java version "1.6.0_31"
          OpenJDK Runtime Environment (IcedTea6 1.13.3) (6b31-1.13.3-1ubuntu1~0.12.04.2)
          OpenJDK 64-Bit Server VM (build 23.25-b01, mixed mode)
        
  Builder version :
          Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 13:51:28+0000)
          Maven home: /opt/apache-maven-3.0.5
          Java version: 1.6.0_31, vendor: Sun Microsystems Inc.
          Java home: /usr/lib/jvm/java-6-openjdk-amd64/jre
          Default locale: en_US, platform encoding: ANSI_X3.4-1968
          OS name: "linux", version: "3.2.0-64-generic", arch: "amd64", family: "unix"
    
****************************************************************************
SCM Changes:
****************************************************************************
Changed: ggregory @ Sat 12 Jul 2014 01:52:46 +0000
Comment: The artifact IDs are commons-dbcp2 and commons-pool2, not commons-dbcp and commons-pool.
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/index.xml ( 1609875 )

Changed: ggregory @ Sat 12 Jul 2014 02:01:12 +0000
Comment: The package is now org.apache.commons.dbcp2, not org.apache.commons.dbcp.
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/index.xml ( 1609877 )

Changed: sebb @ Mon 26 May 2014 14:19:18 +0000
Comment: Document why assembly plugin version is overridden
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1597593 )

Changed: psteitz @ Sat 24 May 2014 16:33:56 +0000
Comment: Comment out README copy.
Files changed:
  /commons/proper/dbcp/trunk/dbcp-release.sh ( 1597316 )

Changed: psteitz @ Sat 24 May 2014 16:35:02 +0000
Comment: Fixed duplicat config (causing warning); updated version.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1597317 )

Changed: psteitz @ Sat 24 May 2014 16:51:20 +0000
Comment: Fixed jta spec version.
Files changed:
  /commons/proper/dbcp/trunk/build.properties.sample ( 1597318 )

Changed: psteitz @ Sat 24 May 2014 16:52:36 +0000
Comment: Updated to reflect 2.0.1 release.
Files changed:
  /commons/proper/dbcp/trunk/src/site/site.xml ( 1597319 )

Changed: psteitz @ Sat 24 May 2014 16:53:33 +0000
Comment: Eliminated need to update minor version reference for each 2.x release.
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/index.xml ( 1597321 )

Changed: psteitz @ Sat 24 May 2014 16:54:21 +0000
Comment: Updated version to reflect 2.0.1 release.
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1597322 )

Changed: psteitz @ Sat 24 May 2014 16:54:59 +0000
Comment: Added 2.0.2 release, updated date of 2.0.1 release.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1597323 )

Changed: psteitz @ Sat 24 May 2014 17:15:42 +0000
Comment: Added last two releases.
Files changed:
  /commons/proper/dbcp/trunk/doap_dbcp.rdf ( 1597326 )

Changed: sebb @ Fri 23 May 2014 15:08:59 +0000
Comment: DBCP-420 InstanceKeyDataSource discards native SQLException when given password does not match password used to create the connection
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1597113 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1597113 )

Changed: markt @ Thu 22 May 2014 12:22:22 +0000
Comment: Code clean-up. No functional change. Import and modifier order.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1596835 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1596835 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1596835 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1596835 )

Changed: markt @ Thu 22 May 2014 12:26:50 +0000
Comment: Code clean-up. No functional change. Import and modifier order.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1596838 )

Changed: markt @ Thu 22 May 2014 12:16:53 +0000
Comment: Use recommended modifier order
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1596832 )

Changed: markt @ Thu 22 May 2014 12:19:13 +0000
Comment: Order imports
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1596833 )

Changed: psteitz @ Sun 18 May 2014 18:04:30 +0000
Comment: What can't go up, must come down. Down-rev assembly plugin to work around MASSEMBLY-637.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1595646 )

Changed: psteitz @ Sun 18 May 2014 18:06:29 +0000
Comment: Limit line-ending adjustment to text files.
Files changed:
  /commons/proper/dbcp/trunk/src/main/assembly/src-tar-gz.xml ( 1595647 )
  /commons/proper/dbcp/trunk/src/main/assembly/src-zip.xml ( 1595647 )

Changed: psteitz @ Sun 18 May 2014 16:11:40 +0000
Comment: Added newlines at EOF.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java ( 1595632 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java ( 1595632 )

Changed: psteitz @ Sat 17 May 2014 04:41:00 +0000
Comment: s/pool/dbcp in some comments.
Files changed:
  /commons/proper/dbcp/trunk/dbcp-RC.sh ( 1595423 )
  /commons/proper/dbcp/trunk/dbcp-pre-RC.sh ( 1595423 )
  /commons/proper/dbcp/trunk/dbcp-release.sh ( 1595423 )

Changed: psteitz @ Fri 16 May 2014 21:29:50 +0000
Comment: Removed quotes, added newline at EOF.
Files changed:
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2/LocalStrings.properties ( 1595358 )

Changed: psteitz @ Fri 16 May 2014 21:42:48 +0000
Comment: Added release scripts.
Files changed:
  /commons/proper/dbcp/trunk/dbcp-RC.sh ( 1595360 )
  /commons/proper/dbcp/trunk/dbcp-pre-RC.sh ( 1595360 )
  /commons/proper/dbcp/trunk/dbcp-release.sh ( 1595360 )

Changed: psteitz @ Tue 13 May 2014 19:56:14 +0000
Comment: Updated for 2.0.1 release.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1594352 )

Changed: psteitz @ Tue 13 May 2014 17:39:59 +0000
Comment: Made release description a sentence.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1594295 )

Changed: psteitz @ Tue 13 May 2014 17:41:22 +0000
Comment: Added periods at the ends of sentences; added newLine at the end of the file.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/release-notes.vm ( 1594296 )

Changed: psteitz @ Tue 13 May 2014 17:43:05 +0000
Comment: Update for 2.0.1 release.
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/download_dbcp.xml ( 1594297 )

Changed: psteitz @ Tue 13 May 2014 17:44:22 +0000
Comment: Updated for 2.0.1.
Files changed:
  /commons/proper/dbcp/trunk/RELEASE-NOTES.txt ( 1594299 )

Changed: psteitz @ Mon 12 May 2014 19:32:44 +0000
Comment: Enable PoolableConnection class to load without JMX. JIRA: DBCP-418
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1594068 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1594068 )

Changed: psteitz @ Fri 2 May 2014 23:32:43 +0000
Comment: Added check in PoolingDataSource constructor to make sure connection factory and pool are linked.  JIRA: DBCP-412.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1592119 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1592119 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2/LocalStrings.properties ( 1592119 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDataSource.java ( 1592119 )

Changed: psteitz @ Fri 2 May 2014 23:44:50 +0000
Comment: Updated change log for DBCP-414.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1592123 )

Changed: psteitz @ Sat 3 May 2014 00:12:47 +0000
Comment: Fixed connection leak when managed connections are closed during transactions. JIRA: DBCP-417.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1592132 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1592132 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java ( 1592132 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java ( 1592132 )

Changed: markt @ Wed 23 Apr 2014 09:47:50 +0000
Comment: Add an assertion to formally check the assertion made in the comments
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1589361 )

Changed: psteitz @ Sun 20 Apr 2014 17:52:58 +0000
Comment: Added missing calls to setPool.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1588805 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDriver.java ( 1588805 )

Changed: psteitz @ Fri 18 Apr 2014 23:23:57 +0000
Comment: Added test verifying that DelegatingStatement close does not re-close wrapped PoolablePreparedStatements. JIRA: DBCP-414.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1588592 )

Changed: psteitz @ Wed 16 Apr 2014 23:58:41 +0000
Comment: Fixed test comment.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1588103 )

Changed: psteitz @ Wed 16 Apr 2014 22:54:28 +0000
Comment: Dropped needless method call.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1588090 )

Changed: psteitz @ Wed 16 Apr 2014 22:12:15 +0000
Comment: Modified DelegatingStatement#close to a) null its delegate reference b) no-op on isClosed. JIRA: DBCP-415.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1588087 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1588087 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1588087 )

Changed: sebb @ Sun 13 Apr 2014 21:51:12 +0000
Comment: FIx invalid Javadoc "tags"
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1587103 )

Changed: sebb @ Sun 13 Apr 2014 22:01:04 +0000
Comment: IGNORE test rather than commenting it out
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1587107 )

Changed: sebb @ Sun 13 Apr 2014 22:07:42 +0000
Comment: Remove redundant Test suite() methods
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingCallableStatement.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingDatabaseMetaData.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingPreparedStatement.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingStatement.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDriverManagerConnectionFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestJndi.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolableConnection.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDriver.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestInstanceKeyDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestKeyedCPDSConnectionFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java ( 1587109 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java ( 1587109 )

Changed: psteitz @ Sun 13 Apr 2014 06:10:44 +0000
Comment: Added test (commented out) to illustrate DBCP-415.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1586926 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1586926 )

Changed: psteitz @ Sat 5 Apr 2014 22:58:54 +0000
Comment: Fixed issue link typo.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1585212 )

Changed: psteitz @ Sat 5 Apr 2014 04:15:30 +0000
Comment: Added missing setPool; updated doco; s/Oracle/h2. JIRA: DBCP-412.
Files changed:
  /commons/proper/dbcp/trunk/doc/PoolingDataSourceExample.java ( 1584958 )

Changed: markt @ Mon 3 Mar 2014 22:43:08 +0000
Comment: Fix broken links
Files changed:
  /commons/proper/dbcp/trunk/src/site/site.xml ( 1573792 )

Changed: markt @ Mon 3 Mar 2014 13:43:28 +0000
Comment: Another small performance tweak.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1573561 )

Changed: markt @ Mon 3 Mar 2014 12:53:57 +0000
Comment: Another small improvement
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1573549 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1573549 )

Changed: markt @ Mon 3 Mar 2014 10:21:23 +0000
Comment: Small performance tweak. The improvement is just about visible.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1573510 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1573510 )

Changed: markt @ Mon 3 Mar 2014 10:16:33 +0000
Comment: Add release date
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1573507 )

Changed: markt @ Mon 3 Mar 2014 10:17:31 +0000
Comment: Increment for next release (assuming it is just a bug fix release)
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1573508 )

Changed: psteitz @ Fri 28 Feb 2014 19:47:09 +0000
Comment: Updated pool dependency.
Files changed:
  /commons/proper/dbcp/trunk/build.properties.sample ( 1573051 )

Changed: markt @ Fri 28 Feb 2014 13:47:51 +0000
Comment: Remove reference to file that doesn't exist.
Re-order
Files changed:
  /commons/proper/dbcp/trunk/src/main/assembly/src-tar-gz.xml ( 1572947 )
  /commons/proper/dbcp/trunk/src/main/assembly/src-zip.xml ( 1572947 )

Changed: markt @ Thu 27 Feb 2014 15:19:57 +0000
Comment: Clean up changes reporting settings
Make the Jira report more useful
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1572616 )

Changed: markt @ Thu 27 Feb 2014 13:34:20 +0000
Comment: Update the index page
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/index.xml ( 1572557 )

Changed: markt @ Thu 27 Feb 2014 13:40:02 +0000
Comment: Fix duplication
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1572564 )

Changed: markt @ Thu 27 Feb 2014 13:55:44 +0000
Comment: Minor re-word
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/index.xml ( 1572575 )

Changed: markt @ Wed 26 Feb 2014 20:29:24 +0000
Comment: Remove @since markers
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableCallableStatement.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java ( 1572236 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1572236 )

Changed: markt @ Wed 26 Feb 2014 20:34:39 +0000
Comment: Add @since 2.0 to all classes
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Constants.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DataSourceConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DriverConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DriverManagerConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableCallableStatement.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionMXBean.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/SwallowedExceptionLogger.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Utils.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSourceFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionAndInfo.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PooledConnectionManager.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSourceFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/UserPassKey.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionContextListener.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java ( 1572242 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/XAConnectionFactory.java ( 1572242 )

Changed: markt @ Wed 26 Feb 2014 20:38:08 +0000
Comment: Add @since 2.0 to inner classes
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572244 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1572244 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1572244 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1572244 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java ( 1572244 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1572244 )

Changed: markt @ Wed 26 Feb 2014 19:41:27 +0000
Comment: Findbugs fixes
Files changed:
  /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml ( 1572216 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1572216 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java ( 1572216 )

Changed: markt @ Wed 26 Feb 2014 19:49:46 +0000
Comment: Findbugs fixes
Make connection count thread safe
Files changed:
  /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml ( 1572217 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1572217 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1572217 )

Changed: markt @ Wed 26 Feb 2014 20:08:27 +0000
Comment: Findbugs fixes
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java ( 1572225 )

Changed: markt @ Wed 26 Feb 2014 18:44:35 +0000
Comment: Drop the old release notes template in favour of the standard one.
Files changed:
  /commons/proper/dbcp/trunk/src/template ( 1572191 )

Changed: markt @ Wed 26 Feb 2014 18:45:03 +0000
Comment: Move comment
Files changed:
  /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml ( 1572192 )

Changed: markt @ Wed 26 Feb 2014 18:52:45 +0000
Comment: Findbugs fixes
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDriver.java ( 1572193 )

Changed: sebb @ Wed 26 Feb 2014 16:20:32 +0000
Comment: Template for generating release notes (copied from NET)
Files changed:
  /commons/proper/dbcp/trunk/src/changes/release-notes.vm ( 1572135 )

Changed: sebb @ Wed 26 Feb 2014 16:21:00 +0000
Comment: How to create release notes using the template
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1572137 )

Changed: sebb @ Wed 26 Feb 2014 16:27:19 +0000
Comment: Tweak description formatting to generate better spacing in Release Notes
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1572145 )

Changed: sebb @ Wed 26 Feb 2014 16:28:20 +0000
Comment: Regenerated release notes
Files changed:
  /commons/proper/dbcp/trunk/RELEASE-NOTES.txt ( 1572146 )

Changed: sebb @ Wed 26 Feb 2014 16:46:51 +0000
Comment: Document Java and Maven name changes
Files changed:
  /commons/proper/dbcp/trunk/RELEASE-NOTES.txt ( 1572157 )
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1572157 )

Changed: markt @ Wed 26 Feb 2014 15:30:28 +0000
Comment: More FindBugs fixes
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1572093 )

Changed: sebb @ Wed 26 Feb 2014 16:03:11 +0000
Comment: DBCP-411 BasicManagedDataSource - unregister from JMX on close()
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1572118 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572118 )

Changed: sebb @ Wed 26 Feb 2014 16:14:37 +0000
Comment: Ensure logger warnings are seen in testing
Use constant for pool version is it is used in several places
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1572131 )

Changed: markt @ Wed 26 Feb 2014 14:51:04 +0000
Comment: Fix some unclosed resource warnings from FindBugs
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1572068 )

Changed: markt @ Wed 26 Feb 2014 14:59:10 +0000
Comment: Exclude a common false positive
Mock objects often return null for unimplemented methods.
Files changed:
  /commons/proper/dbcp/trunk/findbugs-exclude-filter.xml ( 1572072 )

Changed: markt @ Wed 26 Feb 2014 15:05:14 +0000
Comment: Fix FindBugs resource closure warnings
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1572079 )

Changed: markt @ Wed 26 Feb 2014 15:11:39 +0000
Comment: Fix FindBugs resource closure warnings
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1572084 )

Changed: markt @ Wed 26 Feb 2014 15:18:14 +0000
Comment: FindBugs low hanging fruit
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1572088 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java ( 1572088 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPoolingBasicDataSource.java ( 1572088 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterConnection.java ( 1572088 )

Changed: markt @ Wed 26 Feb 2014 13:30:00 +0000
Comment: Drop the PMD plug-in in preference for the built-in FindBugs
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1572047 )

Changed: markt @ Wed 26 Feb 2014 12:29:04 +0000
Comment: PMD fixes
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/ConnectionFactory.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1572030 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1572030 )

Changed: markt @ Wed 26 Feb 2014 12:36:05 +0000
Comment: Remove unused code identified by PMD
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1572032 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1572032 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1572032 )

Changed: markt @ Wed 26 Feb 2014 13:15:58 +0000
Comment: Remove unnecessary code identified by PMD
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1572042 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1572042 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PoolablePreparedStatementStub.java ( 1572042 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1572042 )

Changed: markt @ Wed 26 Feb 2014 11:26:55 +0000
Comment: Review the remaining TODOs within the codebase.
- remove the completed ones
- remove ones that no longer apply
- action the ones that need actioning

Fix some comment typos
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1572012 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestBasicManagedDataSource.java ( 1572012 )

Changed: markt @ Wed 26 Feb 2014 11:42:05 +0000
Comment: Clean-up
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1572016 )

Changed: markt @ Wed 26 Feb 2014 11:42:24 +0000
Comment: Fix checkstyle errors
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1572018 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1572018 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Utils.java ( 1572018 )

Changed: markt @ Wed 26 Feb 2014 12:01:37 +0000
Comment: 'Fix' the remaining checkstyle issue
Files changed:
  /commons/proper/dbcp/trunk/checkstyle.xml ( 1572026 )

Changed: markt @ Wed 26 Feb 2014 12:06:23 +0000
Comment: Fix FindBugs warning
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1572027 )

Changed: markt @ Wed 26 Feb 2014 10:27:34 +0000
Comment: Fix indent
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571991 )

Changed: markt @ Wed 26 Feb 2014 10:36:41 +0000
Comment: There has been no DBCp 1.5 release yet.
Fix typo
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571995 )

Changed: markt @ Wed 26 Feb 2014 10:45:40 +0000
Comment: Update download page.
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/download_dbcp.xml ( 1571997 )

Changed: markt @ Wed 26 Feb 2014 10:49:27 +0000
Comment: Changes for download page generation
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571998 )

Changed: markt @ Wed 26 Feb 2014 11:14:31 +0000
Comment: package.html -> package-info.java
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/package-info.java (from /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/package.html:1571967) ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/package.html ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/package-info.java (from /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/package.html:1571967) ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/package.html ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/package-info.java (from /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/package.html:1571967) ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/package.html ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/package-info.java (from /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/package.html:1571981) ( 1572010 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/package.html ( 1572010 )

Changed: markt @ Wed 26 Feb 2014 09:22:43 +0000
Comment: Update Pool Javadoc link
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571974 )

Changed: markt @ Wed 26 Feb 2014 09:56:43 +0000
Comment: Re-word to avoid invalid direct references to packages
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/package.html ( 1571981 )

Changed: markt @ Wed 26 Feb 2014 09:57:03 +0000
Comment: Build Javadoc without warnings
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571982 )

Changed: markt @ Wed 26 Feb 2014 10:04:52 +0000
Comment: Drop as the Commons web site has much more detailed information.
Files changed:
  /commons/proper/dbcp/trunk/release-process.txt ( 1571983 )

Changed: markt @ Wed 26 Feb 2014 09:13:32 +0000
Comment: Fix line endings in source distros
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571972 )
  /commons/proper/dbcp/trunk/src/main/assembly/src-tar-gz.xml (from /commons/proper/dbcp/trunk/src/main/assembly/src.xml:1571967) ( 1571972 )
  /commons/proper/dbcp/trunk/src/main/assembly/src-zip.xml (from /commons/proper/dbcp/trunk/src/main/assembly/src.xml:1571967) ( 1571972 )
  /commons/proper/dbcp/trunk/src/main/assembly/src.xml ( 1571972 )

Changed: sebb @ Tue 25 Feb 2014 21:25:42 +0000
Comment: Checkstyle fixes (most of the rest)
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1571827 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2/LocalStrings.properties ( 1571827 )

Changed: sebb @ Tue 25 Feb 2014 21:31:11 +0000
Comment: Allow command-line checkstyle use (no need to run site)
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571828 )

Changed: sebb @ Tue 25 Feb 2014 21:36:28 +0000
Comment: Checkstyle
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1571831 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PoolablePreparedStatementStub.java ( 1571831 )

Changed: sebb @ Tue 25 Feb 2014 21:39:22 +0000
Comment: Checkstyle
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Constants.java ( 1571834 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/SwallowedExceptionLogger.java ( 1571834 )

Changed: sebb @ Tue 25 Feb 2014 21:13:39 +0000
Comment: Update to latest versions of plugins
Remove DoubleCheckedLocking check as latest checkstyle does not support it
Files changed:
  /commons/proper/dbcp/trunk/checkstyle.xml ( 1571824 )
  /commons/proper/dbcp/trunk/pom.xml ( 1571824 )

Changed: sebb @ Tue 25 Feb 2014 21:14:00 +0000
Comment: Start working on checkstyle errors
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571825 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1571825 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1571825 )

Changed: sebb @ Tue 25 Feb 2014 19:25:03 +0000
Comment: Tab police
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1571794 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571794 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1571794 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java ( 1571794 )
  /commons/proper/dbcp/trunk/src/site/xdoc/release-notes-1.2.1.xml ( 1571794 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1571794 )
  /commons/proper/dbcp/trunk/test-jar.xml ( 1571794 )

Changed: sebb @ Tue 25 Feb 2014 19:26:51 +0000
Comment: Cobertura is defined in parent pom
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571796 )

Changed: ggregory @ Tue 25 Feb 2014 17:33:00 +0000
Comment: Add final modifier to private fields.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDriverManagerConnectionFactory.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterClassLoader.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1571760 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java ( 1571760 )

Changed: ggregory @ Tue 25 Feb 2014 17:39:56 +0000
Comment: Remove unnecessary parentheses noise: 
return (this.foo); -> return this.foo;
and so on.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DriverManagerConnectionFactory.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Utils.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/UserPassKey.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1571763 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1571763 )

Changed: ggregory @ Tue 25 Feb 2014 17:42:39 +0000
Comment: Add missing Javadoc tag.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java ( 1571765 )

Changed: ggregory @ Tue 25 Feb 2014 17:44:49 +0000
Comment: Simplify: Statement unnecessarily nested within else clause. The corresponding then clause does not complete normally.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PoolKey.java ( 1571766 )

Changed: ggregory @ Tue 25 Feb 2014 17:45:56 +0000
Comment: Access constant directly.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1571767 )

Changed: ggregory @ Tue 25 Feb 2014 17:47:07 +0000
Comment: Access constant directly.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571768 )

Changed: ggregory @ Tue 25 Feb 2014 17:53:34 +0000
Comment: Remove unused import.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571770 )

Changed: ggregory @ Tue 25 Feb 2014 17:54:38 +0000
Comment: Remove unused import. Organize imports.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1571772 )

Changed: ggregory @ Tue 25 Feb 2014 17:56:33 +0000
Comment: Access constant directly.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571773 )

Changed: ggregory @ Tue 25 Feb 2014 17:57:47 +0000
Comment: Access constant directly.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571774 )

Changed: ggregory @ Tue 25 Feb 2014 18:02:35 +0000
Comment: Simplify: Statement unnecessarily nested within else clause.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DataSourceConnectionFactory.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DriverManagerConnectionFactory.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Utils.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571776 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1571776 )

Changed: sebb @ Tue 25 Feb 2014 17:20:23 +0000
Comment: EOL
Files changed:
  /commons/proper/dbcp/trunk/src/template/dbcp-release-notes.vm ( 1571752 )

Changed: ggregory @ Tue 25 Feb 2014 17:20:59 +0000
Comment: Update cobertura-maven-plugin to 2.6 from 2.5.1 fixes the Maven build on Java 7.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571753 )

Changed: markt @ Tue 25 Feb 2014 14:59:25 +0000
Comment: DBCP 2 has a minimum Java version of 7 so no need for JDBC 4 markers.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterCallableStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterConnection.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDatabaseMetaData.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterResultSet.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java ( 1571716 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/PooledConnectionProxy.java ( 1571716 )

Changed: markt @ Tue 25 Feb 2014 12:24:05 +0000
Comment: Update Commons Pool dependency
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1571663 )

Changed: markt @ Tue 25 Feb 2014 12:26:04 +0000
Comment: Fix DBCP-249
Add support for validation on object creation.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1571664 )
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1571664 )

Changed: markt @ Mon 17 Feb 2014 19:38:31 +0000
Comment: Functionality this was testing has been removed.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1569096 )

Changed: markt @ Mon 17 Feb 2014 19:39:01 +0000
Comment: Now validation is using isValid() it needs a basic implementation here.
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterConnection.java ( 1569097 )

Changed: markt @ Mon 17 Feb 2014 12:41:47 +0000
Comment: isValid should not trigger an exception if the connection is closed.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1568965 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1568965 )

Changed: markt @ Mon 17 Feb 2014 13:22:33 +0000
Comment: Fix DBCP-357. Use Connection.isValid() to validate connections unless a validation query has been defined.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1568981 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1568981 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestKeyedCPDSConnectionFactory.java ( 1568981 )

Changed: markt @ Mon 17 Feb 2014 13:33:43 +0000
Comment: Complete rename of maxActive to maxTotal
Files changed:
  /commons/proper/dbcp/trunk/doc/abandon.jsp ( 1568985 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1568985 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1568985 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/package.html ( 1568985 )
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1568985 )
  /commons/proper/dbcp/trunk/src/site/xdoc/guide/jndi-howto.xml ( 1568985 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1568985 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1568985 )

Changed: markt @ Sat 15 Feb 2014 20:01:43 +0000
Comment: Fix problem identified while performance testing validation queries.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1568674 )

Changed: markt @ Sat 15 Feb 2014 19:01:37 +0000
Comment: Add query timeout check to TesterPreparedStatement so validation query timeout test passes
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1568666 )

Changed: markt @ Sat 15 Feb 2014 19:15:08 +0000
Comment: Fix a contention reported by SUM4JVM
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1568668 )

Changed: markt @ Sat 15 Feb 2014 16:31:34 +0000
Comment: Restore code that sets delegate to null otherwise PoolGuardConnectionWrapper can't do what it is meant to.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1568641 )

Changed: markt @ Sat 15 Feb 2014 16:33:00 +0000
Comment: Use a PreparedStatement for the validation query to improve performance. Testing suggests a ~15% improvement with a very basic validation query.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1568643 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1568643 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1568643 )

Changed: markt @ Fri 14 Feb 2014 12:55:35 +0000
Comment: DBCP-340
Provide an option to set the default query timeout.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1568264 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1568264 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1568264 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1568264 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1568264 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1568264 )

Changed: markt @ Fri 14 Feb 2014 11:46:46 +0000
Comment: Fix DBCP-351, DBCP-399
Add two new options:
enableAutoCommitOnReturn
rollbackOnReturn
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1568253 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1568253 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1568253 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1568253 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1568253 )

Changed: markt @ Thu 13 Feb 2014 21:53:12 +0000
Comment: Fix DBCP-373
Modify SharedPoolDataSource and PerUserPoolDataSource to expose all of the configuration properties of the underlying connection pool(s).
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSourceFactory.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSourceFactory.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestKeyedCPDSConnectionFactory.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1568055 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1568055 )

Changed: markt @ Thu 13 Feb 2014 14:08:35 +0000
Comment: Rename for consistency
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSourceFactory.java (from /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java:1567033) ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSourceFactory.java ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1567933 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSourceFactory.java ( 1567933 )

Changed: markt @ Thu 13 Feb 2014 11:45:39 +0000
Comment: Add some JMX to this test so help with debugging
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1567890 )

Changed: markt @ Thu 13 Feb 2014 11:47:18 +0000
Comment: DBCP-219 is complete, add it to the changelog
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1567892 )

Changed: markt @ Thu 13 Feb 2014 11:52:36 +0000
Comment: Fix typo
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1567895 )

Changed: markt @ Thu 13 Feb 2014 11:16:42 +0000
Comment: DBCP-219
Ensure connection is unregistered when it is closed.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1567883 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1567883 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java ( 1567883 )

Changed: markt @ Thu 13 Feb 2014 10:18:01 +0000
Comment: Further work on DBCP-219
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1567876 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Constants.java ( 1567876 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1567876 )

Changed: markt @ Thu 13 Feb 2014 08:59:20 +0000
Comment: First pass at fixing DBCP-219
Expose PoolableConnections via JMX creating an hierarchy pool->connection->statementpool
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1567866 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1567866 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionMXBean.java ( 1567866 )

Changed: markt @ Wed 12 Feb 2014 20:04:37 +0000
Comment: Fix DBCP-309
Improve example for JNDI with BasicDataSource
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1567746 )
  /commons/proper/dbcp/trunk/src/site/xdoc/guide/jndi-howto.xml ( 1567746 )

Changed: sebb @ Tue 11 Feb 2014 15:27:45 +0000
Comment: Add failure messages to identify fails
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1567181 )

Changed: sebb @ Tue 11 Feb 2014 15:32:54 +0000
Comment: Additional tests to try and pin down Continuum test failure
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1567182 )

Changed: markt @ Tue 11 Feb 2014 12:54:25 +0000
Comment: Fix test failure
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1567095 )

Changed: markt @ Tue 11 Feb 2014 10:31:32 +0000
Comment: Fix DBCP-234
The default values for readOnly, autoCommit and transactionIsolation are now taken from the JDBC driver. No calls to setReadOnly(), setAutoCommit() or setTransactionIsolation() will be made for a newly borrowed connection unless a default is explicitly configured (and the connection is currently using a different setting).
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceMXBean.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1567033 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1567033 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestPerUserPoolDataSource.java ( 1567033 )

Changed: markt @ Tue 11 Feb 2014 10:39:37 +0000
Comment: Remove unused code
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1567037 )

Changed: markt @ Tue 11 Feb 2014 10:46:38 +0000
Comment: Fix auto boxing warnings
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDriverManagerConnectionFactory.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolableConnection.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDataSource.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDriver.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1567040 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java ( 1567040 )

Changed: markt @ Mon 10 Feb 2014 09:28:03 +0000
Comment: Fix DBCP-410
Correct path to Javadoc overview in build.xml.
Patch by Andreas Sturmlechner
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1566539 )
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1566539 )

Changed: markt @ Mon 10 Feb 2014 09:28:40 +0000
Comment: Update date
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1566540 )

Changed: markt @ Fri 7 Feb 2014 14:54:12 +0000
Comment: Fix DBCP-177
Enable DBCP to work with a SecurityManager such that only DBCP needs to be granted the necessary permissions to communicate with the database.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1565667 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1565667 )

Changed: markt @ Fri 7 Feb 2014 12:26:29 +0000
Comment: Start work on DBCP-177
Enable getConnection() to work under a security manager
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1565630 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/Utils.java ( 1565630 )

Changed: markt @ Wed 5 Feb 2014 22:30:36 +0000
Comment: Fix DBCP-180
The garbage collector needs to be able to collect JDBC resources that the client is no longer referencing. The AbandonedTrace code was stopping this. This has been fixed by using WeakReferences. A secondary issue was that pooled statements would not get returned to the pool once the WeakReference was used since AbandonedTrace lost the ability to trace all the child resources. Use of a finalizer (I couldn't think of a better way) addresses that.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1564961 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1564961 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1564961 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java ( 1564961 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterUtils.java ( 1564961 )

Changed: markt @ Wed 5 Feb 2014 22:33:07 +0000
Comment: Update changelog
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564963 )

Changed: markt @ Wed 5 Feb 2014 19:56:10 +0000
Comment: Keep FindBugs happy
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1564905 )

Changed: sebb @ Wed 5 Feb 2014 17:09:48 +0000
Comment: Privatise constants - there are public getters
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java ( 1564833 )

Changed: sebb @ Wed 5 Feb 2014 17:13:01 +0000
Comment: constant does not need to be exposed to sub-classes
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1564836 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java ( 1564836 )

Changed: markt @ Wed 5 Feb 2014 13:08:08 +0000
Comment: Fix class cast errors and make it harder to create a similar issue in the future
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1564763 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1564763 )

Changed: markt @ Wed 5 Feb 2014 10:29:19 +0000
Comment: Fix equals() for PStmtKey and remove unnecessary code from sub-class now PStmtKey handles autoGeneratedKeys
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1564702 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1564702 )

Changed: markt @ Wed 5 Feb 2014 10:31:03 +0000
Comment: Simplify SQLException creation
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionContext.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java ( 1564704 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterConnection.java ( 1564704 )

Changed: markt @ Wed 5 Feb 2014 09:31:07 +0000
Comment: Fix DBCP-406
Add support for pooling PreparedStatements that use auto-generated keys.
Patch by Steeve Beroard.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564688 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PStmtKey.java ( 1564688 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1564688 )

Changed: markt @ Tue 4 Feb 2014 19:21:57 +0000
Comment: Sync with Pool 2
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1564430 )

Changed: markt @ Tue 4 Feb 2014 19:23:22 +0000
Comment: Fix DBCP-368
Expose the new Pool 2 property evictionPolicyClassName to enable more sophisticated eviction strategies to be used.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564431 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1564431 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1564431 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1564431 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1564431 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1564431 )

Changed: markt @ Tue 4 Feb 2014 19:36:41 +0000
Comment: Unable to find a way around this final generics warning so suppress it
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1564436 )

Changed: markt @ Tue 4 Feb 2014 13:44:12 +0000
Comment: Fix DBCP-358
The equals() implementations of the DelegatingXxx classes are now symmetric.
There are some important API changes underlying this fix:
- two DelegatingXxx instances are no longer considered equal if they have the same innermost delegate;
- a DelegatingXxx instance is not considered equal to its innermost delegate;
- the getInnermostDelegateInternal() method has been made public (but remains part of the internal API) to allow classes extending this implementation to access the innermost delegate when required.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingCallableStatement.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingDatabaseMetaData.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingPreparedStatement.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingStatement.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPoolingDataSource.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/datasources/TestSharedPoolDataSource.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSource.java ( 1564298 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java ( 1564298 )

Changed: markt @ Tue 4 Feb 2014 11:44:20 +0000
Comment: Fix typos
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestManagedDataSourceInTx.java ( 1564257 )

Changed: markt @ Tue 4 Feb 2014 09:36:15 +0000
Comment: Remove obsolete comment
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1564236 )

Changed: sebb @ Tue 4 Feb 2014 01:27:38 +0000
Comment: Show failure reason
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1564149 )

Changed: markt @ Mon 3 Feb 2014 23:17:59 +0000
Comment: Fix DBCP-372
Using batchUpdate() should not invalidate the PreparedStatement when it is returned to the pool.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564124 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1564124 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestPStmtPooling.java ( 1564124 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterStatement.java ( 1564124 )

Changed: markt @ Mon 3 Feb 2014 21:25:07 +0000
Comment: Fix DBCP-398
Clarify Jaavdoc for isClosed() method of PoolableConnection.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564067 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1564067 )

Changed: markt @ Mon 3 Feb 2014 21:55:11 +0000
Comment: Fix DBCP-383
Avoid NullPointerException and throw an XAException if an attempt is made to commit the current transaction for a connection when no transaction has been started.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1564084 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java ( 1564084 )

Changed: markt @ Mon 3 Feb 2014 14:41:06 +0000
Comment: Return BasicDataSource rather than DataSource from BasicDataSourceFactory so a cast is not required to use BasicDataSource specific methods.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1563924 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1563924 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1563924 )

Changed: markt @ Mon 3 Feb 2014 14:44:53 +0000
Comment: Work-around test failure with IBM JVM
Files changed:
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestConnectionPool.java ( 1563926 )

Changed: markt @ Mon 3 Feb 2014 13:46:06 +0000
Comment: 
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1563892 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/DataSourceXAConnectionFactory.java ( 1563892 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TestDataSourceXAConnectionFactory.java ( 1563892 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/managed/TesterBasicXAConnection.java ( 1563892 )

Changed: markt @ Sun 2 Feb 2014 20:24:20 +0000
Comment: Partial fix for DBCP-404
Make mutable fields private
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1563705 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1563705 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1563705 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableCallableStatement.java ( 1563705 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1563705 )

Changed: markt @ Sun 2 Feb 2014 20:31:43 +0000
Comment: Partial fix for DBCP-404
Make mutable fields private
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1563707 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1563707 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1563707 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1563707 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedDataSource.java ( 1563707 )

Changed: markt @ Sun 2 Feb 2014 20:38:02 +0000
Comment: Fix DBCP-404
Mutable fields should be private
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1563708 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1563708 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java ( 1563708 )

Changed: markt @ Sun 2 Feb 2014 20:44:12 +0000
Comment: Fix DBCP-341
LocalXAConnectionFactory does not properly check if Xid is equal to currentXid when resuming which may result in an XAException.
Patch by Ioannis Canellos
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1563709 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/LocalXAConnectionFactory.java ( 1563709 )

Changed: markt @ Sun 2 Feb 2014 20:03:35 +0000
Comment: Partial fix for DBCP-404
Make mutable fields private
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1563702 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1563702 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java ( 1563702 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1563702 )

Changed: markt @ Sun 2 Feb 2014 20:12:31 +0000
Comment: Partial fix for DBCP-404
Make mutable fields private
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DataSourceConnectionFactory.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/cpdsadapter/ConnectionImpl.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/managed/ManagedConnection.java ( 1563703 )
  /commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestDelegatingConnection.java ( 1563703 )

Changed: ggregory @ Sun 2 Feb 2014 07:03:26 +0000
Comment: Update copyright for 2014.
Files changed:
  /commons/proper/dbcp/trunk/NOTICE.txt ( 1563570 )

Changed: markt @ Fri 31 Jan 2014 20:29:37 +0000
Comment: Clean-up some TODOs. Pool 2 provides the necessary guards.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1563249 )

Changed: markt @ Fri 31 Jan 2014 20:44:56 +0000
Comment: Fix DBCP-391
Ensure that the close state of a pooled connection and the underlying connection is consistent when the underlying connection is closed as a result of an error condition.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1563253 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1563253 )

Changed: markt @ Fri 31 Jan 2014 09:46:14 +0000
Comment: Complete DBCP-348 - clarify differences between setting connectionInitSqls on BasicDataSourceFactory and BasicDataSource.
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1563097 )

Changed: markt @ Fri 31 Jan 2014 09:28:41 +0000
Comment: Fix NPE caused by switch to ConcurrentHashMap identified by unit tests
Files changed:
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1563095 )

Changed: markt @ Thu 30 Jan 2014 21:39:51 +0000
Comment: Fix DBCP-369
Fix threading issue when using multiple instances of the SharedPoolDataSource concurrently.
I can't reproduce this but the issue can be seeing from looking at the code.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1562988 )
  /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1562988 )

Changed: sebb @ Thu 30 Jan 2014 21:09:46 +0000
Comment: Standardise Maven layout
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1562962 )
  /commons/proper/dbcp/trunk/pom.xml ( 1562962 )
  /commons/proper/dbcp/trunk/src/assembly ( 1562962 )
  /commons/proper/dbcp/trunk/src/java ( 1562962 )
  /commons/proper/dbcp/trunk/src/main/assembly (from /commons/proper/dbcp/trunk/src/assembly:1537527) ( 1562962 )
  /commons/proper/dbcp/trunk/src/main/java (from /commons/proper/dbcp/trunk/src/java:1562944) ( 1562962 )
  /commons/proper/dbcp/trunk/src/test/java ( 1562962 )
  /commons/proper/dbcp/trunk/src/test/java/org (from /commons/proper/dbcp/trunk/src/test/org:1562957) ( 1562962 )
  /commons/proper/dbcp/trunk/src/test/org ( 1562962 )

Changed: sebb @ Thu 30 Jan 2014 19:49:02 +0000
Comment: Not needed
Files changed:
  /commons/proper/dbcp/trunk/src/main/resources/assets ( 1562934 )

Changed: sebb @ Thu 30 Jan 2014 19:59:40 +0000
Comment: Deprecations
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1562936 )

Changed: markt @ Thu 30 Jan 2014 20:16:22 +0000
Comment: Fix DBCP-382
Allow accessToUnderlyingConnectionAllowed to be configured when configuration takes place via JNDI in a JavaEE container.
Patch provided by Stefan Rempfer
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1562944 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1562944 )

Changed: sebb @ Thu 30 Jan 2014 19:10:43 +0000
Comment: Sync versions with pom
Files changed:
  /commons/proper/dbcp/trunk/build.properties.sample ( 1562926 )

Changed: sebb @ Thu 30 Jan 2014 19:19:52 +0000
Comment: Fix up build to allow for moved source resources
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1562928 )

Changed: sebb @ Thu 30 Jan 2014 18:43:08 +0000
Comment: Move source resources to correct place
Don't override standard resources from Commons Parent
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1562917 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/LocalStrings.properties ( 1562917 )
  /commons/proper/dbcp/trunk/src/main ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/assets ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/org ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2 ( 1562917 )
  /commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2/LocalStrings.properties (from /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/LocalStrings.properties:1562825) ( 1562917 )

Changed: sebb @ Thu 30 Jan 2014 18:17:11 +0000
Comment: Revert temporary hack
Add direct test to ensure Utils class loads OK
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/Utils.java ( 1562912 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestUtils.java ( 1562912 )

Changed: sebb @ Thu 30 Jan 2014 17:27:29 +0000
Comment: Temporary debug hack
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/Utils.java ( 1562901 )

Changed: sebb @ Thu 30 Jan 2014 17:05:41 +0000
Comment: Add a failure message
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1562895 )

Changed: sebb @ Thu 30 Jan 2014 17:11:06 +0000
Comment: Latest JUnit version
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1562896 )

Changed: sebb @ Thu 30 Jan 2014 17:15:17 +0000
Comment: Rename to avoid variable hiding
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestDelegatingStatement.java ( 1562897 )

Changed: markt @ Thu 30 Jan 2014 13:50:23 +0000
Comment: Fix DBCP-376
Fix thread safety issues in the SharedPoolDataSource and the PerUserPoolDataSource.
Test case and fix based on patches suggested by Dave Oxley.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1562825 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1562825 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1562825 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1562825 )

Changed: markt @ Wed 29 Jan 2014 09:14:44 +0000
Comment: Fix Javadoc
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1562381 )

Changed: markt @ Wed 29 Jan 2014 07:43:24 +0000
Comment: Fix Eclipse warning. password could be null here
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1562374 )

Changed: markt @ Mon 13 Jan 2014 11:32:15 +0000
Comment: Prep for fixing a FindBugs issue in a sub-class
- Add a short-cut to equals for the same object
- Use explicit tests rather than exception handling (should be faster)
- Use all of the fields for the hashCode to improve performance when used in HashTables etc.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PStmtKey.java ( 1557679 )

Changed: markt @ Mon 13 Jan 2014 11:43:16 +0000
Comment: Fix possible NPEs in r1557679
(using Eclipse's generated code for equals() and hashCode() with just formatting changes)
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PStmtKey.java ( 1557682 )

Changed: markt @ Mon 13 Jan 2014 11:46:06 +0000
Comment: Reduce FindBugs warnings (equals() but no hashCode())
(using Eclipse's generated code for equals() and hashCode() with just formatting changes)
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1557684 )

Changed: markt @ Sun 12 Jan 2014 19:01:00 +0000
Comment: Reduce FindBugs warnings
Explicitly define the encoding to use rather than depending on the defaults
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1557598 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1557598 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1557598 )

Changed: markt @ Sun 12 Jan 2014 19:08:05 +0000
Comment: Remove some unused methods
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1557600 )

Changed: markt @ Sun 12 Jan 2014 19:16:20 +0000
Comment: Reduce FindBugs warnings
Take defensive copies of client provided arrays
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1557602 )

Changed: markt @ Sun 12 Jan 2014 17:49:43 +0000
Comment: DBCP-317.
Partial fix. Remove unnecessary equals() methods.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1557570 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java ( 1557570 )

Changed: markt @ Sun 12 Jan 2014 18:01:15 +0000
Comment: Reduce FindBugs warnings
Use valueOf()
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PStmtKey.java ( 1557574 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PStmtKeyCPDS.java ( 1557574 )

Changed: markt @ Sun 12 Jan 2014 18:01:52 +0000
Comment: Reduce FindBugs warnings
Remove unnecessary null check
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1557575 )

Changed: markt @ Sun 12 Jan 2014 18:02:47 +0000
Comment: Reduce FindBugs warnings
Male it explicit that the exception is being ignored
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1557576 )

Changed: markt @ Sun 12 Jan 2014 18:03:14 +0000
Comment: Reduce FindBugs warnings
Use synchronisation consistently
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1557577 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1557577 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1557577 )

Changed: markt @ Sat 11 Jan 2014 19:25:10 +0000
Comment: Fix comment typo
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1557441 )

Changed: markt @ Sat 11 Jan 2014 19:27:17 +0000
Comment: Fix test broken by removing unused code
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/cpdsadapter/TestDriverAdapterCPDS.java ( 1557444 )

Changed: markt @ Sat 11 Jan 2014 19:55:42 +0000
Comment: DBCP-400.
Correct the documentation for the maxOpenPreparedStatements parameter and review the use of the phrase non-positive throughout the documentation and javadoc, replacing it with negative where that is the correct definition to use.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1557453 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1557453 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1557453 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1557453 )
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1557453 )

Changed: markt @ Sat 11 Jan 2014 19:19:05 +0000
Comment: Remove unused code. Note that maxActive was originally meaningless because the pool was configured to grow when exhausted.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1557437 )

Changed: markt @ Sat 11 Jan 2014 16:56:35 +0000
Comment: Fix the examples
Files changed:
  /commons/proper/dbcp/trunk/doc/PoolingDataSourceExample.java ( 1557420 )
  /commons/proper/dbcp/trunk/doc/PoolingDriverExample.java ( 1557420 )

Changed: markt @ Tue 7 Jan 2014 18:06:22 +0000
Comment: Pool 2.1 has had a release so depend on that rather than the snapshot.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1556295 )

Changed: psteitz @ Fri 9 Aug 2013 05:19:32 +0000
Comment: Removed unused imports.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1512139 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1512139 )

Changed: markt @ Thu 1 Aug 2013 16:42:13 +0000
Comment: Javadoc fixes
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1509323 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1509323 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1509323 )

Changed: markt @ Thu 1 Aug 2013 16:47:20 +0000
Comment: Java 7. Use <>
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/InstanceKeyObjectFactory.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/TransactionContext.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/TransactionRegistry.java ( 1509326 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterClassLoader.java ( 1509326 )

Changed: markt @ Tue 23 Jul 2013 23:16:00 +0000
Comment: Fix a couple of Eclipse warnings.
Take advantage of some Java 7 features.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1506365 )

Changed: markt @ Wed 24 Jul 2013 08:03:42 +0000
Comment: Update release description.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1506432 )

Changed: markt @ Wed 24 Jul 2013 08:07:43 +0000
Comment: Fix xml
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1506434 )

Changed: markt @ Wed 24 Jul 2013 08:08:49 +0000
Comment: Add a JIRA reference for an already fixed issue.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1506435 )

Changed: markt @ Wed 24 Jul 2013 08:11:06 +0000
Comment: Make Commons Logging a full dependency of DBCP so DBCP can use it as a logging mechanism.
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1506436 )

Changed: markt @ Wed 24 Jul 2013 09:04:17 +0000
Comment: JIRA-154
Log (at debug level) when a connection fails validation.
This commit also adds i18n support.
Files changed:
  /commons/proper/dbcp/trunk/src/changes/changes.xml ( 1506447 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/LocalStrings.properties ( 1506447 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1506447 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/Utils.java ( 1506447 )

Changed: markt @ Wed 24 Jul 2013 14:14:34 +0000
Comment: Update for recent changes to pool API
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1506568 )

Changed: markt @ Wed 24 Jul 2013 14:15:05 +0000
Comment: Java 7. Use <>
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1506570 )

Changed: markt @ Wed 24 Jul 2013 20:06:42 +0000
Comment: Update for Pool-2 API changes.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1506687 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java ( 1506687 )

Changed: markt @ Wed 24 Jul 2013 21:07:46 +0000
Comment: Java 7 <>
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1506712 )

Changed: markt @ Wed 24 Jul 2013 21:22:13 +0000
Comment: Java 7 <>
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1506725 )

Changed: markt @ Wed 24 Jul 2013 21:25:16 +0000
Comment: Switch test to use same constructor as main code.
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1506726 )

Changed: markt @ Wed 24 Jul 2013 21:27:14 +0000
Comment: Use generics
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/datasources/TestCPDSConnectionFactory.java ( 1506728 )

Changed: markt @ Wed 24 Jul 2013 21:31:56 +0000
Comment: Removed unused constructor
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1506730 )

Changed: markt @ Wed 24 Jul 2013 21:45:17 +0000
Comment: Java 7 <>
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1506737 )

Changed: markt @ Wed 24 Jul 2013 21:58:57 +0000
Comment: DBCP-156
Implement a configuration option - disabled by default - that sets a maximum permitted lifetime for a connection after which the connection will automatically fail the next validation, activation or passivation.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/LocalStrings.properties ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/SharedPoolDataSource.java ( 1506741 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1506741 )

Changed: markt @ Thu 25 Jul 2013 09:22:11 +0000
Comment: DBCP-156
Document new option
Files changed:
  /commons/proper/dbcp/trunk/src/site/xdoc/configuration.xml ( 1506858 )

Changed: markt @ Thu 25 Jul 2013 13:07:03 +0000
Comment: Name change
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1506952 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingConnection.java ( 1506952 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/PooledConnectionImpl.java ( 1506952 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/CPDSConnectionFactory.java ( 1506952 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/KeyedCPDSConnectionFactory.java ( 1506952 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java ( 1506952 )

Changed: markt @ Fri 26 Jul 2013 08:53:52 +0000
Comment: Add a simple toString() implementation to aid debugging in an IDE and to test viewing this class as an object in a pool via JMX.
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1507221 )

Changed: markt @ Fri 26 Jul 2013 08:56:15 +0000
Comment: Simplify
The IDE will know the type and it is better for JMX to determine the type as not all objects will provide that info.
Files changed:
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterPreparedStatement.java ( 1507222 )

Changed: markt @ Fri 26 Jul 2013 13:47:37 +0000
Comment: Make constructors private to ensure creation of DelegatingResultSet instances is always via the static wrapResultSet(...) methods.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1507310 )

Changed: markt @ Fri 26 Jul 2013 15:32:45 +0000
Comment: Document construction requirements.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1507353 )

Changed: markt @ Thu 1 Aug 2013 14:29:21 +0000
Comment: Use the new SwallowedExceptionListener interface for all instances of GOP used by DBCP
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1509249 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/LocalStrings.properties ( 1509249 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/SwallowedExceptionLogger.java ( 1509249 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/PerUserPoolDataSource.java ( 1509249 )

Changed: olamy @ Mon 1 Jul 2013 11:30:21 +0000
Comment: fix javadoc links
Files changed:
  /commons/proper/dbcp/trunk/src/site/site.xml ( 1498387 )

Changed: sebb @ Sun 19 May 2013 10:53:43 +0000
Comment: LANG-894 some doap files have incorrect download page
Files changed:
  /commons/proper/betwixt/trunk/doap_betwixt.rdf ( 1484266 )
  /commons/proper/cli/trunk/doap_cli.rdf ( 1484266 )
  /commons/proper/compress/trunk/doap_compress.rdf ( 1484266 )
  /commons/proper/daemon/trunk/doap_daemon.rdf ( 1484266 )
  /commons/proper/dbcp/trunk/doap_dbcp.rdf ( 1484266 )
  /commons/proper/email/trunk/doap_email.rdf ( 1484266 )
  /commons/proper/exec/trunk/doap_exec.rdf ( 1484266 )
  /commons/proper/fileupload/trunk/doap_fileupload.rdf ( 1484266 )
  /commons/proper/jci/trunk/doap_jci.rdf ( 1484266 )
  /commons/proper/lang/trunk/doap_lang.rdf ( 1484266 )
  /commons/proper/math/trunk/doap_math.rdf ( 1484266 )
  /commons/proper/scxml/trunk/doap_scxml.rdf ( 1484266 )

Changed: sebb @ Sun 24 Mar 2013 14:07:51 +0000
Comment: ASF => The ASF
Files changed:
  /commons/proper/beanutils/trunk/pom.xml ( 1460379 )
  /commons/proper/csv/trunk/pom.xml ( 1460379 )
  /commons/proper/dbcp/trunk/pom.xml ( 1460379 )
  /commons/proper/el/trunk/pom.xml ( 1460379 )
  /commons/proper/email/trunk/pom.xml ( 1460379 )
  /commons/proper/jexl/trunk/pom.xml ( 1460379 )
  /commons/proper/logging/trunk/pom.xml ( 1460379 )
  /commons/proper/pool/trunk/pom.xml ( 1460379 )
  /commons/proper/scxml/trunk/pom.xml ( 1460379 )
  /commons/proper/vfs/trunk/pom.xml ( 1460379 )

Changed: sebb @ Fri 22 Mar 2013 17:49:27 +0000
Comment: Fix up URLs so they point to actual sites; this allows relative URLs to work properly
Files changed:
  /commons/proper/bcel/trunk/pom.xml ( 1459912 )
  /commons/proper/beanutils/trunk/pom.xml ( 1459912 )
  /commons/proper/betwixt/trunk/pom.xml ( 1459912 )
  /commons/proper/bsf/trunk/pom.xml ( 1459912 )
  /commons/proper/chain/trunk/pom.xml ( 1459912 )
  /commons/proper/cli/trunk/pom.xml ( 1459912 )
  /commons/proper/codec/trunk/pom.xml ( 1459912 )
  /commons/proper/collections/trunk/pom.xml ( 1459912 )
  /commons/proper/compress/trunk/pom.xml ( 1459912 )
  /commons/proper/configuration/trunk/pom.xml ( 1459912 )
  /commons/proper/csv/trunk/pom.xml ( 1459912 )
  /commons/proper/daemon/trunk/pom.xml ( 1459912 )
  /commons/proper/dbcp/trunk/pom.xml ( 1459912 )
  /commons/proper/dbutils/trunk/pom.xml ( 1459912 )
  /commons/proper/digester/trunk/pom.xml ( 1459912 )
  /commons/proper/discovery/trunk/pom.xml ( 1459912 )
  /commons/proper/el/trunk/pom.xml ( 1459912 )
  /commons/proper/email/trunk/pom.xml ( 1459912 )
  /commons/proper/exec/trunk/pom.xml ( 1459912 )
  /commons/proper/functor/trunk/pom.xml ( 1459912 )
  /commons/proper/imaging/trunk/pom.xml ( 1459912 )
  /commons/proper/io/trunk/pom.xml ( 1459912 )
  /commons/proper/jci/trunk/pom.xml ( 1459912 )
  /commons/proper/jcs/trunk/pom.xml ( 1459912 )
  /commons/proper/jexl/trunk/pom.xml ( 1459912 )
  /commons/proper/jxpath/trunk/pom.xml ( 1459912 )
  /commons/proper/lang/trunk/pom.xml ( 1459912 )
  /commons/proper/logging/trunk/pom.xml ( 1459912 )
  /commons/proper/math/trunk/pom.xml ( 1459912 )
  /commons/proper/modeler/trunk/pom.xml ( 1459912 )
  /commons/proper/net/trunk/pom.xml ( 1459912 )
  /commons/proper/ognl/trunk/pom.xml ( 1459912 )
  /commons/proper/pool/trunk/pom.xml ( 1459912 )
  /commons/proper/proxy/trunk/pom.xml ( 1459912 )
  /commons/proper/scxml/trunk/pom.xml ( 1459912 )
  /commons/proper/validator/trunk/pom.xml ( 1459912 )
  /commons/proper/vfs/trunk/pom.xml ( 1459912 )

Changed: olamy @ Tue 26 Feb 2013 23:53:27 +0000
Comment: restore download cgi
Files changed:
  /commons/proper/bcel/trunk/src/site/resources/download_bcel.cgi ( 1450539 )
  /commons/proper/beanutils/trunk/src/site/resources/download_beanutils.cgi ( 1450539 )
  /commons/proper/betwixt/trunk/src/site/resources/download_betwixt.cgi ( 1450539 )
  /commons/proper/bsf/trunk/src/site/resources/download_bsf.cgi ( 1450539 )
  /commons/proper/chain/trunk/src/site/resources/download_chain.cgi ( 1450539 )
  /commons/proper/codec/trunk/src/site/resources/download_code.cgi ( 1450539 )
  /commons/proper/configuration/trunk/src/site/resources/download_configuration.cgi ( 1450539 )
  /commons/proper/daemon/trunk/src/site/resources/download_daemon.cgi ( 1450539 )
  /commons/proper/dbcp/trunk/src/site/resources/download_dbcp.cgi ( 1450539 )
  /commons/proper/dbutils/trunk/src/site/resources/download_dbutils.cgi ( 1450539 )
  /commons/proper/digester/trunk/src/site/resources/download_digester.cgi ( 1450539 )
  /commons/proper/discovery/trunk/src/site/resources/download_discovery.cgi ( 1450539 )
  /commons/proper/email/trunk/src/site/resources/download_email.cgi ( 1450539 )
  /commons/proper/fileupload/trunk/src/site/resources/download_fileupload.cgi ( 1450539 )

Changed: sebb @ Wed 30 Jan 2013 21:43:00 +0000
Comment: developed by => developed at
Files changed:
  /commons/proper/attributes/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/bcel/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/beanutils/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/betwixt/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/chain/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/codec/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/collections/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/commons-build/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/commons-build-plugin/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/commons-nightly/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/commons-parent/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/commons-sandbox-parent/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/compress/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/configuration/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/csv/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/daemon/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/dbcp/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/dbutils/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/digester/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/discovery/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/el/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/email/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/exec/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/fileupload/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/functor/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/jci/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/jelly/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/jexl/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/jxpath/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/lang/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/launcher/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/logging/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/math/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/modeler/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/net/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/ognl/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/pool/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/primitives/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/proxy/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/scxml/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/validator/trunk/NOTICE.txt ( 1440692 )
  /commons/proper/vfs/trunk/NOTICE.txt ( 1440692 )

Changed: olamy @ Wed 16 Jan 2013 23:08:39 +0000
Comment: configure svnpubsub
Files changed:
  /commons/proper/dbcp/trunk/pom.xml ( 1434471 )

Changed: markt @ Thu 10 Jan 2013 21:55:36 +0000
Comment: Apply Phil's patch from POOL-229 (with a few tweaks) to switch to Pool2's abandoned object pool support.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/AbandonedConfig.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/AbandonedObjectPool.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/AbandonedTrace.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSourceFactory.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnection.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolableConnectionFactory.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/BasicManagedDataSource.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/PoolableManagedConnection.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/managed/PoolableManagedConnectionFactory.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestAbandonedBasicDataSource.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestAbandonedObjectPool.java ( 1431684 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestBasicDataSourceFactory.java ( 1431684 )

Changed: markt @ Thu 10 Jan 2013 16:57:07 +0000
Comment: Update DBCP2 to require JDBC 4.1 (Java 7) since Java 6 is close to end of life and a DBCP2 release is still a little way off.
Files changed:
  /commons/proper/dbcp/trunk/build.xml ( 1431496 )
  /commons/proper/dbcp/trunk/pom.xml ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/BasicDataSource.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingConnection.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingResultSet.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/DelegatingStatement.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingDataSource.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolingDriver.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/cpdsadapter/DriverAdapterCPDS.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/datasources/InstanceKeyDataSource.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterCallableStatement.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterConnection.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterDatabaseMetaData.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterDriver.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterResultSet.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TesterStatement.java ( 1431496 )
  /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/datasources/ConnectionPoolDataSourceProxy.java ( 1431496 )

Changed: markt @ Thu 10 Jan 2013 16:57:20 +0000
Comment: Update year
Files changed:
  /commons/proper/dbcp/trunk/NOTICE.txt ( 1431497 )

Changed: tn @ Wed 7 Nov 2012 15:55:05 +0000
Comment: Fix typo.
Files changed:
  /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp2/PoolablePreparedStatement.java ( 1406683 )

****************************************************************************
Dependencies Changes:
****************************************************************************
No dependencies changed


****************************************************************************
Build Definition:
****************************************************************************
POM filename: pom.xml
Goals: clean deploy   
Arguments: --batch-mode -Pjava-1.6 -Dgpg.skip -Prelease
Build Fresh: false
Always Build: false
Default Build Definition: true
Schedule: COMMONS_SCHEDULE
Profile Name: Maven 3.0.5
Description: Group (shared) Maven 3 Build Definition (Java 1.6)

****************************************************************************
Test Summary:
****************************************************************************
Tests: 0
Failures: 0
Errors: 0
Total time: 0.0




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org