You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/02 17:37:16 UTC
Review Request 27488: Configs: not prompted when changes are not
saved when clicking on scv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27488/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Srimanth Gunturi.
Bugs: AMBARI-8107
https://issues.apache.org/jira/browse/AMBARI-8107
Repository: ambari
Description
-------
If I make a config change, and attempt to navigate away prior to saving, I am prompted that i have changes to cancel/discard/save if I click on another service, or a top main nav.
If I click on another service config version, I am not prompted and then lose my changes.
Diffs
-----
ambari-web/app/controllers/main/service/info/configs.js 3a873e0
ambari-web/app/templates/common/configs/config_history_flow.hbs 68d6b11
ambari-web/app/templates/common/configs/service_version_box.hbs 8bd8434
ambari-web/app/views/common/configs/config_history_flow.js 2e3a3e4
ambari-web/test/controllers/main/service/info/config_test.js aace90b
Diff: https://reviews.apache.org/r/27488/diff/
Testing
-------
4826 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 27488: Configs: not prompted when changes are not
saved when clicking on scv
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27488/#review59524
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Nov. 2, 2014, 4:37 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27488/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 4:37 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8107
> https://issues.apache.org/jira/browse/AMBARI-8107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If I make a config change, and attempt to navigate away prior to saving, I am prompted that i have changes to cancel/discard/save if I click on another service, or a top main nav.
> If I click on another service config version, I am not prompted and then lose my changes.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 3a873e0
> ambari-web/app/templates/common/configs/config_history_flow.hbs 68d6b11
> ambari-web/app/templates/common/configs/service_version_box.hbs 8bd8434
> ambari-web/app/views/common/configs/config_history_flow.js 2e3a3e4
> ambari-web/test/controllers/main/service/info/config_test.js aace90b
>
> Diff: https://reviews.apache.org/r/27488/diff/
>
>
> Testing
> -------
>
> 4826 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 27488: Configs: not prompted when changes are not
saved when clicking on scv
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27488/#review59534
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Лис. 2, 2014, 4:37 після полудня, Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27488/
> -----------------------------------------------------------
>
> (Updated Лис. 2, 2014, 4:37 після полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8107
> https://issues.apache.org/jira/browse/AMBARI-8107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If I make a config change, and attempt to navigate away prior to saving, I am prompted that i have changes to cancel/discard/save if I click on another service, or a top main nav.
> If I click on another service config version, I am not prompted and then lose my changes.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 3a873e0
> ambari-web/app/templates/common/configs/config_history_flow.hbs 68d6b11
> ambari-web/app/templates/common/configs/service_version_box.hbs 8bd8434
> ambari-web/app/views/common/configs/config_history_flow.js 2e3a3e4
> ambari-web/test/controllers/main/service/info/config_test.js aace90b
>
> Diff: https://reviews.apache.org/r/27488/diff/
>
>
> Testing
> -------
>
> 4826 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>