[jira] [Commented] (HADOOP-10657) Have RetryInvocationHandler log failover attempt at INFO level

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020417#comment-14020417 ] 

Hadoop QA commented on HADOOP-10657:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648719/HADOOP-10657.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4022//console

This message is automatically generated.

> Have RetryInvocationHandler log failover attempt at INFO level
> --------------------------------------------------------------
>
>                 Key: HADOOP-10657
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10657
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HADOOP-10657.patch
>
>
> RetryInovcationHandler uses worthLogging flag to decide if it will do logging. worthLogging will be false for first fails over given invocationFailoverCount is zero. That addresses the log noise where the second-listed NN is active.
> For other failover scenarios, it will be useful to log the error message at info level for analysis purpose.



--
This message was sent by Atlassian JIRA
(v6.2#6252)