[GitHub] [lucene] janhoy commented on a change in pull request #359: LUCENE-9488: more distribution artifacts

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #359:
URL: https://github.com/apache/lucene/pull/359#discussion_r723921857



##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -80,6 +81,20 @@ configure(subprojects.findAll { it.path in rootProject.published }) { prj ->
           }
         }
       }
+
+      maven {
+        name = "ApacheReleases"
+        url = apacheNexusReleases
+
+        credentials {
+          def nexusUserName = rootProject.propertyOrDefault('asfNexusUsername', null)

Review comment:
       How will we pass username to the build? `gradlew -PasfNexusUsername=janhoy -PasfNexusPassword=foo`? I suppose it is the RM's ASF credentials that will be used?

##########
File path: gradle/publishing/defaults-maven.gradle
##########
@@ -58,6 +58,7 @@ configure(rootProject) {
     ]
 
     apacheNexusSnapshots = "https://repository.apache.org/content/repositories/snapshots"
+    apacheNexusReleases = "https://repository.apache.org/service/local/staging/deploy/maven2"

Review comment:
       This was parameterized in the ant build with `-Dm2.maven.repository.url` or something along those lines, but that was probably a requirement of that plugin. I think it is better to have that URL here in gradle config than in releaseWizard.

##########
File path: lucene/packaging/build.gradle
##########
@@ -204,13 +220,15 @@ task assembleSourceDist() {
                     "archive",

Review comment:
       There are more options to `archive` to e.g. exclude certain files etc. Should we consider excluding `.github` and perhaps some other files that are not related to the source or build?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org