You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 15:46:59 UTC
[jira] [Created] (CASSANDRA-3871) Turn compression on by default
Turn compression on by default
------------------------------
Key: CASSANDRA-3871
URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 1.1
Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3871) Turn compression on by default
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203765#comment-13203765 ]
Sylvain Lebresne commented on CASSANDRA-3871:
---------------------------------------------
It would be cleaner to centralize the handling of null in CompressionParameters.parseCompressorClass(). I'd also prefer using the empty string to set no compression (partly because I think it's more natural, but also partly because I don't want to have to care about some special casing of the grammar for CASSANDRA-3783).
bq. IMO a 2ary index CF should "inherit" the compression setting for its parent.
Agreed. But as this is not fully related to that issue, I've created CASSANDRA-3877 for that.
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871-v1.patch, CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3871) Turn compression on by default
Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-3871:
---------------------------------------
Attachment: CASSANDRA-3871-v2.patch
Overlooked that I can do that in CompressionParameters, fixed. Check for "null" as 'sstable_compression' is removed, users can use 'sstable_compression' set to '' to disable compression.
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871-v1.patch, CASSANDRA-3871-v2.patch, CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3871) Turn compression on by default
Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-3871:
---------------------------------------
Attachment: CASSANDRA-3871.patch
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3871) Turn compression on by default
Posted by "Pavel Yaskevich (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pavel Yaskevich updated CASSANDRA-3871:
---------------------------------------
Attachment: CASSANDRA-3871-v1.patch
I forgot about CQL, v1 turns compression on by default if CF is created using CQL (cql, cql3) and also adds a check to 'create columnfamily' and 'alter table' to disable compression if 'compression_parameters:sstable_compression' was set to 'null'.
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871-v1.patch, CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3871) Turn compression on by default
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203783#comment-13203783 ]
Sylvain Lebresne commented on CASSANDRA-3871:
---------------------------------------------
+1
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871-v1.patch, CASSANDRA-3871-v2.patch, CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3871) Turn compression on by default
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203585#comment-13203585 ]
Sylvain Lebresne commented on CASSANDRA-3871:
---------------------------------------------
I believe this only turn compression on for column family initially created from a thrift structure, as otherwise the default in CFMetaData.init() is still to not use compression. I believe this has 2 consequences that I can see:
# it doesn't set compression by default for CF created through CQL, since CreateColumnFamilyStatement uses CFMetaData directly. we should at least fix that one.
# it doesn't set compression by default for the system CF, nor for secondary indexes. But for those one, that may be something we want, I don't know. On the one side, if we think compression is a better default, why not use it for everything, but on the other side, the user has not way to disable compression for those, so we may want to wait a little bit more before enabling it there.
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3871) Turn compression on by default
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203619#comment-13203619 ]
Jonathan Ellis commented on CASSANDRA-3871:
-------------------------------------------
IMO a 2ary index CF should "inherit" the compression setting for its parent.
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
> Attachments: CASSANDRA-3871.patch
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-3871) Turn compression on by default
Posted by "Jonathan Ellis (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-3871:
-----------------------------------------
Assignee: Pavel Yaskevich (was: Jonathan Ellis)
> Turn compression on by default
> ------------------------------
>
> Key: CASSANDRA-3871
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3871
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Pavel Yaskevich
> Fix For: 1.1
>
>
> Compression has been available but off by default since 1.0.0. It's enabled in a lot of production environments now, with no major problems found. (Some problems with customizing the block size were found and fixed in the 1.0 releases.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira