[GitHub] [beam] damccorm commented on pull request #17374: [BEAM-11105] Stateful watermark estimation

[GitBox <gi...@apache.org>]

damccorm commented on PR #17374:
URL: https://github.com/apache/beam/pull/17374#issuecomment-1099531103

   R: @lostluck 
   
   @lostluck for expediency/context, I'll probably just keep looping you into the watermark reviews immediately, rather than letting the bot round robin. If you disagree with that decision, let me know.
   
   This one is a bigger PR than I'd prefer. If you want me to split it up, let me know and I will - the advantage here is that we get to see the full functionality working E2E. If you want to review it in pieces, I'd split it into:
   
   - the validation + generation (graph/fn.go, graph/fn_test.go, genx/genx.go, genx/genx_test.go)
   - the invoker changes (exec/sdf_invokers.go, exec/sdf_invokers_test.go)
   - the sdf execution + encoding changes (exec/sdf.go, exec/sdf_test.go, pardo.go, exec/dynsplit_test.go)
   
   If you would like me to split it up, that is how I would do it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org