You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alexandreyc (via GitHub)" <gi...@apache.org> on 2026/03/11 16:24:11 UTC

[PR] Minor: make signatures of `SessionContext::register_*` methods consistent [datafusion]

alexandreyc opened a new pull request, #20873:
URL: https://github.com/apache/datafusion/pull/20873

   ## Which issue does this PR close?
   
   None.
   
   ## Rationale for this change
   
   All `register_*` methods on `SessionContext` should have similar signatures for the sake of API consistency.
   
   ## What changes are included in this PR?
   
   Update `SessionContext::register_batch` and `SessionContext::register_arrow` to have similar signatures than the rest of `SessionContext::register_*` methods.
   
   ## Are these changes tested?
   
   I don't think any tests are required for this. Type checking done by the compiler should be enough. Let me know if you disagree.
   
   ## Are there any user-facing changes?
   
   I don't think so. All previous calls to these methods should still work as before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Minor: make signatures of `SessionContext::register_*` methods consistent [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #20873:
URL: https://github.com/apache/datafusion/pull/20873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Minor: make signatures of `SessionContext::register_*` methods consistent [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #20873:
URL: https://github.com/apache/datafusion/pull/20873#issuecomment-4067744873

   Thanks again @alexandreyc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Minor: make signatures of `SessionContext::register_*` methods consistent [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #20873:
URL: https://github.com/apache/datafusion/pull/20873#issuecomment-4054371466

   Thank you @alexandreyc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org