[jira] [Commented] (REEF-1265) Clean up constructors for xUnit in ReefFunctionalTests

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205828#comment-15205828 ] 

Markus Weimer commented on REEF-1265:
-------------------------------------

This does make the code cleaner, but it also introduces a fragile base class we extend a lot. On the java side, we've solved the same issue with composition: The setup routines as well as the job submission (and reporting) is all done via a {{TestEnvironment}} which is itself instantiated via a factory pattern. That way, we can retarget the whole setup YARN, Mesos, ... by changing that one class only.

Of course, actually integrating Tang with xUnit / jUnit would be even nicer. But pragmatically, the factory has served us well.

> Clean up constructors for xUnit in ReefFunctionalTests
> ------------------------------------------------------
>
>                 Key: REEF-1265
>                 URL: https://issues.apache.org/jira/browse/REEF-1265
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>            Priority: Minor
>
> All constructors in O.A.R.Tests inherited from {{ReefFunctionalTest}} perform the same {{Init()}} action. We can replace them all with one constructor in {{ReefFunctionalTest}} to make the code cleaner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)