[jira] [Commented] (ACCUMULO-2805) Exclude unused HTTP Components from thrift dependency

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997206#comment-13997206 ] 

ASF subversion and git services commented on ACCUMULO-2805:
-----------------------------------------------------------

Commit 7e9cb850a6ade7d098b11d42f8c52713ed4942d3 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from [~busbey]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7e9cb85 ]

ACCUMULO-2805 exclude unused transitive dep.


> Exclude unused HTTP Components from thrift dependency
> -----------------------------------------------------
>
>                 Key: ACCUMULO-2805
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2805
>             Project: Accumulo
>          Issue Type: Task
>          Components: build
>    Affects Versions: 1.5.0, 1.5.1, 1.6.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>
> libthrift pulls in the http components library for the THttpClient. AFAICT, we don't use this part of thrift.
> In 1.6+, we do use an annotation from http components within our plugin, but that module declares a direct dependency.
> When we go to handle our packaging we include libthrift but we purposefully don't include the transitive httpcomponents libraries.
> We should exclude the httpcomponents dependencies from our declaration of libthrift to preemptively avoid problems that would occur if some module (other than the maven plugin) starts making use of httpcomponents without declaring it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)