[jira] [Comment Edited] (CELIX-329) framework "service_" tests are outdates, some small bugs in the sources

["Menno van der Graaf (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CELIX-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062261#comment-15062261 ] 

Menno van der Graaf edited comment on CELIX-329 at 12/17/15 4:23 PM:
---------------------------------------------------------------------

attached a patch that fixes the tests, as for the "service_registry" files the following prolems are fixed:
	source:
-line 417: checking wrong status
-line 784: casting a "hash_map_pt" to "service_registration_pt"
-some small spelling mistakes
-some non exposed functions not declared as static
	mock:
-out of date, many functions are only present in the mock after the refactor
	and header:
-line 38: the values of the hashMap "registry.serviceRegistrations" are described as service registrations, while the values are actually arrayLists of registrations
-line 64: "serviceRegistry_findRegistration" is declared here, but there is no implementation, only the mock defenition remains


was (Author: mercotui):
attached a patch that fixes the tests, as for the "service_registry" files the following prolems are fixed:
	source:
-line 417: checking wrong status
-line 784: casting a "hash_map_pt" to "service_registration_pt"
-some small spelling mistakes
-some non exposed functions not declared as static
	mock:
-out of date, many functions are only present in the mock after the refactor
	and header:
-line 38: the values of the hashMap "registry->serviceRegistrations" are described as service registrations, while the values are actually arrayLists of registrations
-line 64: "serviceRegistry_findRegistration" is declared here, but there is no implementation, only the mock defenition remains

> framework "service_" tests are outdates, some small bugs in the sources
> -----------------------------------------------------------------------
>
>                 Key: CELIX-329
>                 URL: https://issues.apache.org/jira/browse/CELIX-329
>             Project: Celix
>          Issue Type: Bug
>          Components: Framework
>            Reporter: Menno van der Graaf
>         Attachments: service_refactor_tests.patch
>
>
> The tests for the "service_reference", "service_registry", and "service_tracker" are out of date (after the refactoring of the registry)
> there are also some small bugs in the "service_registry"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)