[GitHub] [airflow] feluelle commented on pull request #8877: Add S3ToRedshift example dag and system test

[GitBox <gi...@apache.org>]

feluelle commented on pull request #8877:
URL: https://github.com/apache/airflow/pull/8877#issuecomment-639691781


   My variables which are not committed and I used for testing are:
   
   _variables.env_
   ```
   S3_BUCKET=test-airflow-bucket-${AIRFLOW_BREEZE_UNIQUE_SUFFIX}
   TF_VAR_s3_bucket=${S3_BUCKET}
   TF_VAR_redshift_cluster_identifier=test-airflow-cluster-${AIRFLOW_BREEZE_UNIQUE_SUFFIX}
   HOST_AIRFLOW_SOURCES=/Users/feluelle/PycharmProjects/incubator-airflow
   ```
   and _terraform.tfvars_
   ```
   aws_region = "eu-central-1"
   redshift_database_name = "dev"
   redshift_master_username = "master"
   redshift_master_password = "1Two3Four"
   ```
   
   I added _terraform.tfvars_ to .gitignore, because I was not sure if we should commit it since it contains "sensitive information" eventhough we only use it for testing.
   
   The full example dag takes about 7 mins to run.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org