You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "anentropic (via GitHub)" <gi...@apache.org> on 2024/11/18 17:32:06 UTC

[I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

anentropic opened a new issue, #1333:
URL: https://github.com/apache/iceberg-python/issues/1333

   ### Feature Request / Improvement
   
   https://py.iceberg.apache.org/configuration/#catalogs
   
   > There are three ways to pass in configuration:
   >
   > - Using the `~/.pyiceberg.yaml` configuration file
   > - Through environment variables
   > - By passing in credentials through the CLI or the Python API
   
   I don't want a global iceberg config for my whole machine, I want a file that lives in my project directory that could be potentially checked into git
   
   there is already a search order and fall-back logic for home dir vs `PYICEBERG_HOME` env value 
   
   https://github.com/apache/iceberg-python/blob/main/pyiceberg/utils/config.py#L69-L74
   
   ...so it just needs to do the logical thing and try the current working dir before either of those


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #1333: .pyiceberg.yaml config files should be loaded from current dir instead of home folder
URL: https://github.com/apache/iceberg-python/issues/1333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #1333: .pyiceberg.yaml config files should be loaded from current dir instead of home folder
URL: https://github.com/apache/iceberg-python/issues/1333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #1333:
URL: https://github.com/apache/iceberg-python/issues/1333#issuecomment-2489407439

   It is inspired by how AWS handles credentials in `~/.aws/credentials` with the different profiles.
   
   That said, I'm not against adding the current directory as the last fallback. Are you interested in adding this to the codebase?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #1333:
URL: https://github.com/apache/iceberg-python/issues/1333#issuecomment-2489387317

   > I don't want a global iceberg config for my whole machine, I want a file that lives in my project directory that could be potentially checked into git
   
   Aren't you afraid of checking in credentials?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1333:
URL: https://github.com/apache/iceberg-python/issues/1333#issuecomment-2487478138

   > I don't want a global iceberg config for my whole machine, I want a file that lives in my project directory that could be potentially checked into git
   
   that's an interesting use case. what do you think about this search order? 
   * PYICEBERG_HOME
   * home directory
   * current directory
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "anentropic (via GitHub)" <gi...@apache.org>.
anentropic commented on issue #1333:
URL: https://github.com/apache/iceberg-python/issues/1333#issuecomment-2487759065

   It should check the current dir first since it is the most specific
   
   e.g. then you could use the global home dir file for most things but override that on a particular project with a project-local config file instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] .pyiceberg.yaml config files should be loaded from current dir instead of home folder [iceberg-python]

Posted by "anentropic (via GitHub)" <gi...@apache.org>.
anentropic commented on issue #1333:
URL: https://github.com/apache/iceberg-python/issues/1333#issuecomment-2489400660

   true I probably wouldn't check it in
   
   but I'd never put it in my home folder either way, it seems like a project file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org