You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2024/10/18 05:11:10 UTC
[PR] OAK-11209: added state check util in oak-commons [jackrabbit-oak]
rishabhdaim opened a new pull request, #1809:
URL: https://github.com/apache/jackrabbit-oak/pull/1809
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11209: added state check util in oak-commons [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #1809:
URL: https://github.com/apache/jackrabbit-oak/pull/1809#discussion_r1805891480
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/conditions/Validate.java:
##########
@@ -32,11 +32,11 @@ private Validate() {
// no instances for you
}
- private static Logger LOG = LoggerFactory.getLogger(Validate.class);
+ private static final Logger LOG = LoggerFactory.getLogger(Validate.class);
// when true, message template are arguments checked even when the condition
// to check for is true
- private static boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
+ private static final boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
Review Comment:
uh! good catch :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11209: added state check util in oak-commons [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #1809:
URL: https://github.com/apache/jackrabbit-oak/pull/1809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11209: added state check util in oak-commons [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1809:
URL: https://github.com/apache/jackrabbit-oak/pull/1809#discussion_r1805905943
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/conditions/Validate.java:
##########
@@ -32,11 +32,11 @@ private Validate() {
// no instances for you
}
- private static Logger LOG = LoggerFactory.getLogger(Validate.class);
+ private static final Logger LOG = LoggerFactory.getLogger(Validate.class);
// when true, message template are arguments checked even when the condition
// to check for is true
- private static boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
+ private static final boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
Review Comment:
courtesy `intelliJ`.
##########
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/conditions/Validate.java:
##########
@@ -32,11 +32,11 @@ private Validate() {
// no instances for you
}
- private static Logger LOG = LoggerFactory.getLogger(Validate.class);
+ private static final Logger LOG = LoggerFactory.getLogger(Validate.class);
// when true, message template are arguments checked even when the condition
// to check for is true
- private static boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
+ private static final boolean CHECKMESSAGETEMPLATE = SystemPropertySupplier
Review Comment:
courtesy `IntelliJ`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-11209: added state check util in oak-commons [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #1809:
URL: https://github.com/apache/jackrabbit-oak/pull/1809#issuecomment-2421452943
if checkArgument and checkState are so similar, may we can refactor them into unified methods with a flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org