You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 00:25:50 UTC

[GitHub] [airflow] uranusjr commented on issue #20457: Release 3.0.0 of Amazon Provider

uranusjr commented on issue #20457:
URL: https://github.com/apache/airflow/issues/20457#issuecomment-999185822


   On the surface level, the `AwsBaseHook.expand_role()` now calls `_get_credentials()` with no arguments, which is not supported on older versions, and thus if someone subclasses the hook to reimplement `_get_credentials()`, the code would break after upgrade.
   
   More deeply though, `expand_role()` used to depend on boto’s `get_client_type()` with a dynamic client type, which is deprecated in newer Boto versions. Tt now uses `_get_credentials()` instead to avoid the deprecation. But `expand_role()` does not tak a region argument and therefore cannot pass one to `_get_credentials()`. If we keep compatibility on `_get_credentials()`, we’d break compatibility on `expand_role()` instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org