You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:39:34 UTC
Review Request 66013: Windows: Made ZooKeeper use default CRT linking.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Repository: mesos
Description
-------
Also deleted extraneous patch files.
Diffs
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/zookeeper-06d3f3f.patch 7f66875c7ef8bea3cc077d064b90e056c706487f
3rdparty/zookeeper-3.4.8.patch c532a696f8bf3373b7341ddf32dcf9c528ee4412
3rdparty/zookeeper-3.5.2-alpha.patch 6d5db536437b22a2903c1fa3348613e12fd35df0
Diff: https://reviews.apache.org/r/66013/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT
linking.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/#review199463
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 19, 2018, 12:14 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66013/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 12:14 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8659
> https://issues.apache.org/jira/browse/MESOS-8659
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also deleted extraneous patch files.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3
> 3rdparty/zookeeper-06d3f3f.patch 7f66875c7ef8bea3cc077d064b90e056c706487f
> 3rdparty/zookeeper-3.4.8.patch c532a696f8bf3373b7341ddf32dcf9c528ee4412
> 3rdparty/zookeeper-3.5.2-alpha.patch 6d5db536437b22a2903c1fa3348613e12fd35df0
>
>
> Diff: https://reviews.apache.org/r/66013/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT
linking.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/
-----------------------------------------------------------
(Updated March 19, 2018, 12:14 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-8659
https://issues.apache.org/jira/browse/MESOS-8659
Repository: mesos
Description
-------
Also deleted extraneous patch files.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3
3rdparty/zookeeper-06d3f3f.patch 7f66875c7ef8bea3cc077d064b90e056c706487f
3rdparty/zookeeper-3.4.8.patch c532a696f8bf3373b7341ddf32dcf9c528ee4412
3rdparty/zookeeper-3.5.2-alpha.patch 6d5db536437b22a2903c1fa3348613e12fd35df0
Diff: https://reviews.apache.org/r/66013/diff/3/
Changes: https://reviews.apache.org/r/66013/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT
linking.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/
-----------------------------------------------------------
(Updated March 14, 2018, 4:16 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-8659
https://issues.apache.org/jira/browse/MESOS-8659
Repository: mesos
Description
-------
Also deleted extraneous patch files.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
3rdparty/zookeeper-06d3f3f.patch 7f66875c7ef8bea3cc077d064b90e056c706487f
3rdparty/zookeeper-3.4.8.patch c532a696f8bf3373b7341ddf32dcf9c528ee4412
3rdparty/zookeeper-3.5.2-alpha.patch 6d5db536437b22a2903c1fa3348613e12fd35df0
Diff: https://reviews.apache.org/r/66013/diff/2/
Changes: https://reviews.apache.org/r/66013/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66013: Windows: Made ZooKeeper use default CRT
linking.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66013/#review199033
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On March 9, 2018, 10:39 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66013/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 10:39 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8659
> https://issues.apache.org/jira/browse/MESOS-8659
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also deleted extraneous patch files.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> 3rdparty/zookeeper-06d3f3f.patch 7f66875c7ef8bea3cc077d064b90e056c706487f
> 3rdparty/zookeeper-3.4.8.patch c532a696f8bf3373b7341ddf32dcf9c528ee4412
> 3rdparty/zookeeper-3.5.2-alpha.patch 6d5db536437b22a2903c1fa3348613e12fd35df0
>
>
> Diff: https://reviews.apache.org/r/66013/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>