You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2008/02/10 11:45:08 UTC
[jira] Created: (HTTPCLIENT-745) no classes with default visibility
no classes with default visibility
----------------------------------
Key: HTTPCLIENT-745
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-745
Project: HttpComponents HttpClient
Issue Type: Improvement
Reporter: Roland Weber
Priority: Minor
Fix For: 4.0 Beta 1
There should be no classes with default (package) visibility. They cause problems when classes using them are extended. All classes should either be public, or nested with protected visibility where they are used. Nesting with private visibility may be acceptable in certain cases, for example in final classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-745) no classes with default
visibility
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599626#action_12599626 ]
Sebb commented on HTTPCLIENT-745:
---------------------------------
Agreed - apart from the issue of encapsulation, shared variables (if not final) are generally not thread-safe.
> no classes with default visibility
> ----------------------------------
>
> Key: HTTPCLIENT-745
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-745
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Priority: Minor
> Fix For: 4.0 Beta 1
>
>
> There should be no classes with default (package) visibility. They cause problems when classes using them are extended. All classes should either be public, or nested with protected visibility where they are used. Nesting with private visibility may be acceptable in certain cases, for example in final classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-745) no classes with default
visibility
Posted by "Sam Berlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599617#action_12599617 ]
Sam Berlin commented on HTTPCLIENT-745:
---------------------------------------
Along with these visibility fixes, I think some attention should be placed on classes who shared their variables directly (as opposed to through a getter). This is sometimes OK for subclasses, but rarely good for other classes that use the objects. There's a small number of classes that have non-private variables, especially in the impl.conn & impl.conn.tsccm packages.
> no classes with default visibility
> ----------------------------------
>
> Key: HTTPCLIENT-745
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-745
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Priority: Minor
> Fix For: 4.0 Beta 1
>
>
> There should be no classes with default (package) visibility. They cause problems when classes using them are extended. All classes should either be public, or nested with protected visibility where they are used. Nesting with private visibility may be acceptable in certain cases, for example in final classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-745) no classes with default
visibility
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-745.
------------------------------------------
Resolution: Fixed
Fixed in SVN trunk
Oleg
> no classes with default visibility
> ----------------------------------
>
> Key: HTTPCLIENT-745
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-745
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Priority: Minor
> Fix For: 4.0 Beta 1
>
>
> There should be no classes with default (package) visibility. They cause problems when classes using them are extended. All classes should either be public, or nested with protected visibility where they are used. Nesting with private visibility may be acceptable in certain cases, for example in final classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org