Re: [I] [C++][FlightRPC] Fix ODBC tests for MacOS [arrow]

["vanshaj2023 (via GitHub)" <gi...@apache.org>]

vanshaj2023 commented on issue #49268:
URL: https://github.com/apache/arrow/issues/49268#issuecomment-3905094515

   Hi! I'd like to work on this issue.
   
   **Implementation Approach:**
   
   From reviewing the codebase, I noticed there's already a comment in `odbc_handle.h` (L56-57) that mentions exception handling issues on macOS where `DriverException` doesn't properly catch subclass exceptions. The main areas I plan to investigate:
   
   1. **Exception Handling**: Fix the try-catch blocks in `ODBCHandle::Execute()` to properly catch subclass exceptions on macOS (AuthenticationException, NullWithoutIndicatorException)
   
   2. **Test Environment Setup**: Review test fixture initialization in `odbc_test_suite.cc` - particularly the `ODBCMockTestBase::SetUp()` and remote test base classes to ensure proper connection/teardown on macOS
   
   3. **Platform-Specific Handling**: Check if there are any Linux/Windows-specific assumptions in the test code that break on macOS (e.g., buffer size calculations, string encoding differences)
   
   4. **CMake Configuration**: Verify ODBC library linking in `CMakeLists.txt` works correctly for macOS
   
   Would you be able to assign this issue to me? Also, does this implementation approach sound right, or is there something specific about the MacOS failures I should focus on first? Any guidance on which tests are currently failing would be helpful.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org