You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/06 09:55:08 UTC
[GitHub] [arrow-rs] tustvold opened a new issue, #2664: unary_dyn returns PrimitiveArray for DictionaryArray
tustvold opened a new issue, #2664:
URL: https://github.com/apache/arrow-rs/issues/2664
**Which part is this question about**
<!--
Is it code base, library api, documentation or some other part?
-->
The implementation for unary_dyn currently iterates the dictionary keys, looking up the corresponding value for each non-null key, and storing the result in a PrimitiveArray.
Aside from being grossly inefficient, it seems counter-intuitive at least to me that calling dyn_unary would change the type of the array.
**Describe your question**
<!--
A clear and concise description of what the question is.
-->
Should this kernel instead just apply the unary operation to the dictionary values, leaving the keys unchanged?
**Additional context**
<!--
Add any other context about the problem here.
-->
Tagging @viirya @sunchao who implemented and reviewed this implementation initially in https://github.com/apache/arrow-rs/pull/1990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed issue #2664: unary_dyn returns PrimitiveArray for DictionaryArray
Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2664: unary_dyn returns PrimitiveArray for DictionaryArray
URL: https://github.com/apache/arrow-rs/issues/2664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on issue #2664: unary_dyn returns PrimitiveArray for DictionaryArray
Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2664:
URL: https://github.com/apache/arrow-rs/issues/2664#issuecomment-1237932627
Nvm brain fart, too early in the morning :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org