You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/10 13:06:39 UTC
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #243:
drivers/net/telnet.c: correct typo error to fix build break
liuguo09 opened a new pull request #243: drivers/net/telnet.c: correct typo error to fix build break
URL: https://github.com/apache/incubator-nuttx/pull/243
Signed-off-by: liuhaitao <li...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #243:
drivers/net/telnet.c: correct typo error to fix build break
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #243: drivers/net/telnet.c: correct typo error to fix build break
URL: https://github.com/apache/incubator-nuttx/pull/243#issuecomment-584167348
@xiaoxiang781216 No problem. I brought that minor coding standard fix in when I ran nxstyle against all of the arch/sim files for pr241. It is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #243: drivers/net/telnet.c: correct typo error to fix build break
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #243: drivers/net/telnet.c: correct typo error to fix build break
URL: https://github.com/apache/incubator-nuttx/pull/243#discussion_r377116317
##########
File path: drivers/net/telnet.c
##########
@@ -306,7 +306,6 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
signo = SIGINT;
break;
}
- else
#endif
#ifdef CONFIG_TTY_SIGSTP
Review comment:
I will provide a patch fix this soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#243: drivers/net/telnet.c: correct typo error to fix build break
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #243: drivers/net/telnet.c: correct typo error to fix build break
URL: https://github.com/apache/incubator-nuttx/pull/243#discussion_r377058095
##########
File path: drivers/net/telnet.c
##########
@@ -306,7 +306,6 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
signo = SIGINT;
break;
}
- else
#endif
#ifdef CONFIG_TTY_SIGSTP
Review comment:
In this case, the coding standard will require a blank line after the #endif. nxstyle should report this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis merged pull request #243:
drivers/net/telnet.c: correct typo error to fix build break
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #243: drivers/net/telnet.c: correct typo error to fix build break
URL: https://github.com/apache/incubator-nuttx/pull/243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services