You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/01 08:42:00 UTC

[GitHub] [tvm] ekalda commented on a change in pull request #7754: [PatternMatcher] Support matching tuples, call nodes, and functions with variable numbers of inputs

ekalda commented on a change in pull request #7754:
URL: https://github.com/apache/tvm/pull/7754#discussion_r605478688



##########
File path: tests/python/relay/test_dataflow_pattern.py
##########
@@ -1375,6 +1392,63 @@ def test_partition_overused():
     assert pattern.partition(out) == out
 
 
+def test_partition_fuzzy_tuple():
+    x = relay.var("x")
+    y = relay.var("y")
+    z = x + y
+    tuple_pattern = is_tuple(None)

Review comment:
       I'm fine with it, I think all alternatives to None are non-obvious in their own way. Maybe worth adding an example to https://tvm.apache.org/docs/langref/relay_pattern.html# so that people would be aware of this functionality and the interface? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org