You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by HelKim <17...@qq.com> on 2021/03/16 12:33:04 UTC
回复: 回复: Beginner-friendly issues
Hi,
I have submitted a PR for it.
Thanks!
------------------ 原始邮件 ------------------
发件人: "dev" <qjl16@mails.tsinghua.edu.cn>;
发送时间: 2021年3月16日(星期二) 晚上6:27
收件人: "dev"<dev@iotdb.apache.org>;
主题: Re: 回复: Beginner-friendly issues
Hi,
Great! Removing the measurement which value is empty is an acceptable solution :)
To go a step further, we could design how to pass null values in the Session interface or SQL. (this may need a lot discussion)
Thanks,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
&gt; -----原始邮件-----
&gt; 发件人: HelKim &lt;179949895@qq.com&gt;
&gt; 发送时间: 2021-03-16 15:17:58 (星期二)
&gt; 收件人: dev <dev@iotdb.apache.org>
&gt; 抄送:
&gt; 主题: 回复: Beginner-friendly issues
&gt;
&gt; I have found the problem, insert row plan will try to parse String to Float since&nbsp;temperature is Float type. But the string is empty so it cause some error. I try to convert to null Object if String is empty, but it casue a WAL failed. So, I need to remove the measurement which value is empty before insert? Or it has other better solutions? Thanks!
&gt;
&gt;
&gt;
&gt;
&gt; ------------------&nbsp;原始邮件&nbsp;------------------
&gt; 发件人: "我自己的邮箱" &lt;179949895@qq.com&gt;;
&gt; 发送时间:&nbsp;2021年3月15日(星期一) 晚上10:56
&gt; 收件人:&nbsp;"dev"<dev@iotdb.apache.org&gt;;>
&gt; 主题:&nbsp;回复: Beginner-friendly issues
&gt;
&gt;
&gt;
&gt; Thanks, I will try it.
&gt;
&gt;
&gt;
&gt;
&gt; ------------------ 原始邮件 ------------------
&gt; 发件人: "dev" <qjl16@mails.tsinghua.edu.cn&gt;;> 发送时间:&nbsp;2021年3月15日(星期一) 晚上9:25
&gt; 收件人:&nbsp;"dev"<dev@iotdb.apache.org&gt;;>
&gt; 主题:&nbsp;Re: Beginner-friendly issues
&gt;
&gt;
&gt;
&gt; Hi HelKim,
&gt;
&gt; Here is an issue [1] about the csv tools. You could have a try :)
&gt; This involves the client api and schema of IoTDB.
&gt;
&gt; [1] https://issues.apache.org/jira/browse/IOTDB-1234
&gt;
&gt; Thanks,
&gt; --
&gt; Jialin Qiao
&gt; School of Software, Tsinghua University
&gt;
&gt; 乔嘉林
&gt; 清华大学 软件学院
&gt;
&gt; &amp;gt; -----原始邮件-----
&gt; &amp;gt; 发件人: HelKim &amp;lt;179949895@qq.com&amp;gt;
&gt; &amp;gt; 发送时间: 2021-03-15 17:00:31 (星期一)
&gt; &amp;gt; 收件人: dev <dev@iotdb.apache.org&gt;> &amp;gt; 抄送:
&gt; &amp;gt; 主题: Beginner-friendly issues
&gt; &amp;gt;
&gt; &amp;gt; Hi, I'm HelKim.&amp;nbsp;I'm very interested in this project but I 'm new to it. Is there any issues suitable for me? Thanks!
&gt; </dev@iotdb.apache.org&gt;></dev@iotdb.apache.org&gt;;></qjl16@mails.tsinghua.edu.cn&gt;;></dev@iotdb.apache.org&gt;;></dev@iotdb.apache.org>
Re: 回复: Beginner-friendly issues
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi KelKim,
I merged your PR.
But then I realize that you miss a Test.
Normally, when fixing a bug, we need:
1. find the reason and fix it.
2. Add a test case to approve the issues is solved.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
HelKim <17...@qq.com> 于2021年3月16日周二 下午8:33写道:
> Hi,
> I have submitted a PR for it.
> Thanks!
>
>
>
>
>