You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2025/09/17 06:39:30 UTC

[PR] chore: Xcode 26 fixes for CI [cordova-ios]

dpogue opened a new pull request, #1561:
URL: https://github.com/apache/cordova-ios/pull/1561

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   CI builds are failing due to Xcode version shenanigans
   
   
   ### Description
   <!-- Describe your changes in detail -->
   * Use the `CDV_IOS_SIM` environment variable to control the simulator version used for the spec tests as well as the integration tests
   * Use a default of "iPhone 16e" for `CDV_IOS_SIM` (since that is available in both Xcode 16.4 and 26 with iOS 18 and 26 in GHA)
   * Update the Xcode projects to the latest Xcode settings
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tested locally with Xcode 26 and on GHA CI with Xcode 16.4 and 26
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] chore: Xcode 26 fixes for CI [cordova-ios]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1561:
URL: https://github.com/apache/cordova-ios/pull/1561#issuecomment-3301543408

   ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1561?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 74.18%. Comparing base ([`9cef57c`](https://app.codecov.io/gh/apache/cordova-ios/commit/9cef57c696a2a141becc1179c517efcc55bd45f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`77dd602`](https://app.codecov.io/gh/apache/cordova-ios/commit/77dd602f6eb243cc40c046513832b070ed9dd1d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/cordova-ios/pull/1561?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [lib/build.js](https://app.codecov.io/gh/apache/cordova-ios/pull/1561?src=pr&el=tree&filepath=lib%2Fbuild.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliL2J1aWxkLmpz) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cordova-ios/pull/1561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1561       +/-   ##
   ===========================================
   + Coverage        0   74.18%   +74.18%     
   ===========================================
     Files           0       17       +17     
     Lines           0     4911     +4911     
   ===========================================
   + Hits            0     3643     +3643     
   - Misses          0     1268     +1268     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1561?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] chore: Xcode 26 fixes for CI [cordova-ios]

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #1561:
URL: https://github.com/apache/cordova-ios/pull/1561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Re: [PR] chore: Xcode 26 fixes for CI [cordova-ios]

Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on PR #1561:
URL: https://github.com/apache/cordova-ios/pull/1561#issuecomment-3301542720

   This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/apache/cordova-ios/security/code-scanning?query=pr%3A1561+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org