You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2026/05/23 05:20:37 UTC

[PR] MINOR: Fix typo in DynamicBrokerConfigTest [kafka]

FrankYang0529 opened a new pull request, #22352:
URL: https://github.com/apache/kafka/pull/22352

   props3 -> props


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo in DynamicBrokerConfigTest [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #22352:
URL: https://github.com/apache/kafka/pull/22352#discussion_r3292137139


##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -247,8 +247,8 @@ class DynamicBrokerConfigTest {
     val err2 = assertThrows(classOf[ConfigException], () => config.dynamicConfig.validate(props2, perBrokerConfig = false))
     assertTrue(err2.getMessage.contains("value should be at least half the current value"))
 
-    val props3 = new Properties()
-    props3.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")
+    val props = new Properties()
+    props.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")

Review Comment:
   For consistency, we should use the name prop3, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo in DynamicBrokerConfigTest [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #22352:
URL: https://github.com/apache/kafka/pull/22352#discussion_r3292148744


##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -247,8 +247,8 @@ class DynamicBrokerConfigTest {
     val err2 = assertThrows(classOf[ConfigException], () => config.dynamicConfig.validate(props2, perBrokerConfig = false))
     assertTrue(err2.getMessage.contains("value should be at least half the current value"))
 
-    val props3 = new Properties()
-    props3.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")
+    val props = new Properties()
+    props.put(RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP, "-1")

Review Comment:
   Sorry for that. I misunderstand original comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix typo in DynamicBrokerConfigTest [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 merged PR #22352:
URL: https://github.com/apache/kafka/pull/22352


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org