You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/03 22:07:07 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4069: Revert "add support for parquet reader"

codecov-io commented on issue #4069: Revert "add support for parquet reader"
URL: https://github.com/apache/incubator-pinot/pull/4069#issuecomment-479676218
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=h1) Report
   > Merging [#4069](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/fdd9b921de9716caf26e8398bd611e43967ee9a7?src=pr&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4069/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #4069      +/-   ##
   ===========================================
   - Coverage     66.86%   66.7%   -0.17%     
     Complexity       20      20              
   ===========================================
     Files          1035    1033       -2     
     Lines         51434   51384      -50     
     Branches       7198    7195       -3     
   ===========================================
   - Hits          34393   34277     -116     
   - Misses        14668   14760      +92     
   + Partials       2373    2347      -26
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ain/java/org/apache/pinot/core/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0F2cm9VdGlscy5qYXZh) | `41.48% <ø> (-4.05%)` | `0 <0> (ø)` | |
   | [...e/pinot/core/data/readers/RecordReaderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyRmFjdG9yeS5qYXZh) | `34.78% <ø> (+1.44%)` | `0 <0> (ø)` | :arrow_down: |
   | [...org/apache/pinot/core/data/readers/FileFormat.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvRmlsZUZvcm1hdC5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ache/pinot/core/data/readers/AvroRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQXZyb1JlY29yZFJlYWRlci5qYXZh) | `83.33% <78.94%> (-3.34%)` | `0 <0> (ø)` | |
   | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `20.28% <0%> (-59.43%)` | `0% <0%> (ø)` | |
   | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `26.74% <0%> (-50%)` | `0% <0%> (ø)` | |
   | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `43.33% <0%> (-38.34%)` | `0% <0%> (ø)` | |
   | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `68.88% <0%> (-13.34%)` | `0% <0%> (ø)` | |
   | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `75% <0%> (-4.17%)` | `0% <0%> (ø)` | |
   | ... and [25 more](https://codecov.io/gh/apache/incubator-pinot/pull/4069/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=footer). Last update [fdd9b92...bb57c10](https://codecov.io/gh/apache/incubator-pinot/pull/4069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org