You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/05 02:09:05 UTC
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1196: Refactor audio
patacongo commented on a change in pull request #1196:
URL: https://github.com/apache/incubator-nuttx/pull/1196#discussion_r435652052
##########
File path: drivers/audio/audio_null.c
##########
@@ -771,11 +772,12 @@ static int null_ioctl(FAR struct audio_lowerhalf_s *dev, int cmd,
#endif
default:
+ ret = -EINVAL;
Review comment:
This NuttX convention is that if the ioctl functions does not recognize the command, it returns ENOTTY, not EINVAL.
See https://en.wikipedia.org/wiki/Not_a_typewriter which is how NutX does things in ioctls too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org