You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/07/06 03:54:26 UTC
[kudu-CR] loadgen: honor table num replicas contract
Hello Will Berkeley, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10878
to review the following change.
Change subject: loadgen: honor table_num_replicas contract
......................................................................
loadgen: honor table_num_replicas contract
The description for table_num_replicas says that a value of 0 means use the
server-side default. Except that if you try to use 0 right now, you'll get
an error: "illegal replication factor 0 (replication factor must be odd)".
Passing 0 all the way to the server is rightfully an error; to get the
server-side default, the client needs to leave this field blank.
Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/10878/1
--
To view, visit http://gerrit.cloudera.org:8080/10878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
Gerrit-Change-Number: 10878
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] loadgen: honor table num replicas contract
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10878 )
Change subject: loadgen: honor table_num_replicas contract
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
Gerrit-Change-Number: 10878
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 04:21:01 +0000
Gerrit-HasComments: No
[kudu-CR] loadgen: honor table num replicas contract
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10878 )
Change subject: loadgen: honor table_num_replicas contract
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
Gerrit-Change-Number: 10878
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 06:21:51 +0000
Gerrit-HasComments: No
[kudu-CR] loadgen: honor table num replicas contract
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10878 )
Change subject: loadgen: honor table_num_replicas contract
......................................................................
loadgen: honor table_num_replicas contract
The description for table_num_replicas says that a value of 0 means use the
server-side default. Except that if you try to use 0 right now, you'll get
an error: "illegal replication factor 0 (replication factor must be odd)".
Passing 0 all the way to the server is rightfully an error; to get the
server-side default, the client needs to leave this field blank.
Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
Reviewed-on: http://gerrit.cloudera.org:8080/10878
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_perf.cc
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia978b266e4a81a35495e6366f8938ac337c3645c
Gerrit-Change-Number: 10878
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>