[GitHub] [iceberg] rdsr commented on a change in pull request #1154: Replaced RuntimeIOException with Java 8 UncheckedIOException

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #1154:
URL: https://github.com/apache/iceberg/pull/1154#discussion_r448475846



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -277,7 +277,7 @@ private static void deleteFiles(FileIO io, Set<ManifestFile> allManifests) {
               }
             }
           } catch (IOException e) {
-            throw new RuntimeIOException(e, "Failed to read manifest file: " + manifest.path());
+            throw new UncheckedIOException("Failed to read manifest file: " + manifest.path(), e);

Review comment:
       I do see some public APIs are being affected. E.g  `createTable`.  Do you guys think it is safer to make ` RuntimeOIException` extend `UncheckedIOE` instead of replacing RuntimeIOException completely?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org