[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#discussion_r366620914
 
 

 ##########
 File path: gobblin-utility/src/main/java/org/apache/gobblin/util/HiveAvroTypeConstants.java
 ##########
 @@ -66,4 +66,17 @@
       .put("date",      ImmutableSet.<String>builder().add("string", "varchar").build())
       .put("binary",    Sets.<String>newHashSet())
       .put("boolean",    Sets.<String>newHashSet()).build();
+
+  /**
+   * Following are supported Avro logical types where they would be mapped to corresponding Hive types:
+   * Decimal -> "decimal"
+   * Date -> "date"
+   * TIME_MILLIS = "timestamp"
+   */
+  public static final String DECIMAL = "decimal";
+  public static final String DATE = "date";
+  public static final String TIME_MILLIS = "time-millis";
+
+  public static final Map<String, String> LOGICAL_TYPE_MAPPING = ImmutableMap
 
 Review comment:
   Good catch, not being used anymore

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services