You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/06 13:36:52 UTC

[GitHub] [skywalking-java] Cool-Coding commented on a diff in pull request #140: Fix Grpc 1.x plugin could leak context due to gRPC cancelled

Cool-Coding commented on code in PR #140:
URL: https://github.com/apache/skywalking-java/pull/140#discussion_r843960015


##########
CHANGES.md:
##########
@@ -35,6 +35,7 @@ Release Notes.
 * [Breaking Change] Remove the namespace from `cross process propagation` key.
 * Make sure the parent endpoint in tracing context from existing first ENTRY span, rather than first span only.
 * Fix the bug that maybe causing memory leak and repeated traceId when use gateway-2.1.x-plugin or gateway-3.x-plugin.
+* Fix Grpc 1.x plugin's tracing problem

Review Comment:
   > 
   
   The leaked context causes other grpc request's tracing problem. I think it may be more reasonable belonging to tracing problem. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org