You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by wangyum <gi...@git.apache.org> on 2017/03/04 05:40:53 UTC

[GitHub] incubator-hivemall pull request #59: [HIVEMALL-85] Upgrade hivemall-xgboost'...

GitHub user wangyum opened a pull request:

    https://github.com/apache/incubator-hivemall/pull/59

    [HIVEMALL-85] Upgrade hivemall-xgboost's hadoop version to 2.6.5

    ## What changes were proposed in this pull request?
    
    Upgrade hivemall-xgboost's hadoop version to 2.6.5
    
    ## What type of PR is it?
    
    Improvement
    
    ## What is the Jira issue?
    
    [HIVEMALL-85](https://issues.apache.org/jira/browse/HIVEMALL-85)
    
    ## How was this patch tested?
    
    manual tests
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/incubator-hivemall HIVEMALL-85

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hivemall/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
    
----
commit 66b6be5e5041ddc27476e43bfabfb12b12e5d427
Author: Yuming Wang <wg...@gmail.com>
Date:   2017-03-04T05:29:28Z

    Upgrade hivemall-xgboost's hadoop version to 2.6.5

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    @wangyum Why you select `2.6.5` in this pr? Any reason?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    Be consistent with the Spark.
    https://github.com/apache/spark/blob/d76c18746bdd0908bae89e62da9667001be75624/pom.xml#L125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall pull request #59: [HIVEMALL-85] Upgrade hivemall-xgboost'...

Posted by wangyum <gi...@git.apache.org>.
Github user wangyum closed the pull request at:

    https://github.com/apache/incubator-hivemall/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    We need to change whole dependencies to v2.4.0 following the way in https://github.com/myui/hivemall/tree/dev/yarnkit
    
    File a ticket https://issues.apache.org/jira/browse/HIVEMALL-86
    
    I would like to move the discussions to [Hivemall-86](https://issues.apache.org/jira/browse/HIVEMALL-86).
    
    @wangyum Could you close this pull request?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    Mostly for historical reasons. Better to change the version dependencies to 2.4.0 but dependencies packages change and careful verification is required.
    
    This branch changed the dependencies to 2.4.0 
    https://github.com/myui/hivemall/tree/dev/yarnkit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    @wangyum Thanks for your continuous contributions! 
    @myui do we have any reason to have a dependency with hadoop-core `0.20.2-cdh3u6`? I just used this dependency along with the other modules.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    Yea, I know, but why we use cdh instead of hadoop community version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    
    [![Coverage Status](https://coveralls.io/builds/10436747/badge)](https://coveralls.io/builds/10436747)
    
    Coverage increased (+0.3%) to 37.03% when pulling **66b6be5e5041ddc27476e43bfabfb12b12e5d427 on wangyum:HIVEMALL-85** into **1cccf66829e2c9f6b6e51046c1fc8c19c9aff51b on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hivemall issue #59: [HIVEMALL-85] Upgrade hivemall-xgboost's hadoo...

Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:

    https://github.com/apache/incubator-hivemall/pull/59
  
    @wangyum @maropu I think it's `provided` maven space and thus no need to change.
    `provided` scope libraries are used just for compiling and not bundled in jars.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---