You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/19 21:32:58 UTC

[jira] [Commented] (NIFI-3153) Update AWS SDK

    [ https://issues.apache.org/jira/browse/NIFI-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15762367#comment-15762367 ] 

ASF GitHub Bot commented on NIFI-3153:
--------------------------------------

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1341

    NIFI-3153 Update AWS SDK

    As part of upgrading the AWS SDK, I ran the suite of AWS integration tests.  Getting the integration tests to succeed required a couple of changes detailed below, none of which I believe to be caused by the SDK change:
    
    * ITPutS3Object.testGetPropertyDescriptors - bumped up the expected number of Property Descriptors to match the actual number.
    * ITPutS3Object.testContentType - Ignored. The test checks if the content type was written to the flowfile attributes after writing the content to S3.  I did not find any place in the PutS3Object code that attempts this, uses the S3_CONTENT_TYPE constant, or that was submitted with NIFI-2810.  I created a separate ticket to investigate, NIFI-3228.
    
    ----
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-3153-update-aws-sdk-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1341
    
----
commit eb75984af8d1185bab26c12b70da8f8a2568f313
Author: James Wing <jv...@gmail.com>
Date:   2016-12-17T21:30:27Z

    NIFI-3153 Updating AWS SDK Version

----


> Update AWS SDK
> --------------
>
>                 Key: NIFI-3153
>                 URL: https://issues.apache.org/jira/browse/NIFI-3153
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: James Wing
>            Assignee: James Wing
>            Priority: Minor
>
> I propose to update NiFi's AWS SDK to v1.11.68 (December 16, 2016) or later to get support for recent AWS updates:
> * New Regions - ap-south-1 (Mumbai), ca-central-1 (Canada), eu-west-2 (London), us-east-2 (Ohio)
> * New AWS services
> NiFi's current SDK is v1.11.8 (June 16, 2016).  I looked through the [AWS SDK for Java release notes|https://aws.amazon.com/releasenotes/Java?browse=1] to search for upgrade complications.  Most of the changes look fine -- mostly new services, regions, and simple bug fixes.   I found one item of interest:
> * New [Retry Throttling|https://aws.amazon.com/blogs/developer/introducing-retry-throttling/] feature has been made the default rather than optional starting in [v1.11.12|https://aws.amazon.com/releasenotes/Java/2878241577606051].  It looks very sensible to not flog the system pointlessly if requests are already failing, and I  expect it to be a benefit for most NiFi/AWS use cases.  However, it is the kind of sneaky behavioral change I was looking for.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)