[jira] [Created] (CB-5012) Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin

["Shazron Abdullah (JIRA)" <ji...@apache.org>]

Shazron Abdullah created CB-5012:
------------------------------------

             Summary: Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin
                 Key: CB-5012
                 URL: https://issues.apache.org/jira/browse/CB-5012
             Project: Apache Cordova
          Issue Type: Bug
          Components: Plugman
    Affects Versions: Master
            Reporter: Shazron Abdullah
            Priority: Critical
             Fix For: 3.2.0


See attached .original.plist and .after-plugman.plist.

The plugin.xml used is: https://github.com/apache/cordova-labs/blob/86fb3afef5aaaba8e82e5bf0719b74b4a07582e0/statusbar/plugin.xml
(note the value it tries to add in the iOS Info.plist).

What plugman does is, it adds extra info (newlines, spaces) as the string value for     the keys NSMainNibFile and NSMainNibFile~ipad in Info.plist. They had no values before. At runtime, iOS will search for these "values" and not finding them, crash.

This is critical for plugins that need to modify the Info.plist, like the Facebook PhoneGap plugin. There was a pull request for this, but I don't know why it was closed exactly: https://github.com/apache/cordova-plugman/pull/21

Expected:
plugman should not modify plist keys that have empty string values.

Actual:
plugman should adds a newline, 6 spaces, and another newline for keys that have empty string values.





--
This message was sent by Atlassian JIRA
(v6.1#6144)