[GitHub] [skywalking] lujiajing1126 commented on issue #10479: [Bug] Spring plugins choose wrong interception point to set http status code

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on issue #10479:
URL: https://github.com/apache/skywalking/issues/10479#issuecomment-1455494877

   > > But since the underlying `org.apache.coyote.Response` has a default value of `200`, it always set `200` to the tag.
   > 
   > Is this true? `200` is a default value and if the status code is not `200`, `org.apache.coyote.Response#getStatusCode` should return other values than `200`. This is what we want, defaulting to `200` unless otherwise set, no?
   
   No. I meant the moment we get status code from `org.apache.coyote.Response#getStatusCode`, it always returns the default value. The actual status code is set latter in `HttpEntityMethodProcessor`. That's the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org