You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/17 15:24:36 UTC

[GitHub] [dolphinscheduler] liubo1990 opened a new pull request, #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md

liubo1990 opened a new pull request, #10493:
URL: https://github.com/apache/dolphinscheduler/pull/10493

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   fix a link  for StackOverflow  in docs/docs/zh/development/have-questions.md
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   befor fix
   ![image](https://user-images.githubusercontent.com/10627684/174328304-6f70db50-4fd2-4a55-bd8f-75601f899b61.png)
   ![image](https://user-images.githubusercontent.com/10627684/174328319-35a3a47d-302f-4277-a475-6890cd198079.png)
   
   
   after fix
   ![image](https://user-images.githubusercontent.com/10627684/174328526-c7876520-b172-4afa-8bb1-15c6e494bacb.png)
   ![image](https://user-images.githubusercontent.com/10627684/174328544-a0ad026f-98c3-4e45-97d5-53b4e23f1f3f.png)
   
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
     - *Added dolphinscheduler-dao tests for end-to-end.*
     - *Added CronUtilsTest to verify the change.*
     - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] liubo1990 closed pull request #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md

Posted by GitBox <gi...@apache.org>.
liubo1990 closed pull request #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md
URL: https://github.com/apache/dolphinscheduler/pull/10493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] liubo1990 commented on pull request #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md

Posted by GitBox <gi...@apache.org>.
liubo1990 commented on PR #10493:
URL: https://github.com/apache/dolphinscheduler/pull/10493#issuecomment-1159383421

   > I test in both website https://dolphinscheduler.apache.org/zh-cn/development/have-questions.html and github source https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/development/have-questions.md and it work correctly. could you please rebase to latest code @liubo1990
   
   I just updated the code again from the github source, then opened the docs/docs/en/development/have-questions.md file in IntelliJ IDEA, still the same problem, but the test website https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/development/have-questions.md is correct, I don't understand what's going on  @zhongjiajie


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10493:
URL: https://github.com/apache/dolphinscheduler/pull/10493#issuecomment-1159359502

   I test in both website https://dolphinscheduler.apache.org/zh-cn/development/have-questions.html and github source https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/development/have-questions.md and it work correctly. could you please rebase to latest code @liubo1990 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10493: [fix][doc] fix a link for StackOverflow in docs/docs/zh/development/have-questions.md

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10493:
URL: https://github.com/apache/dolphinscheduler/pull/10493#issuecomment-1165388306

   It work fine in my computer
   ![image](https://user-images.githubusercontent.com/15820530/175507159-c3e2725b-08b8-42c8-b97f-245be268d5de.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org