You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2018/06/01 16:41:17 UTC
[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive
Hello Jim Apple, Attila Jeges,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10486
to look at the new patch set (#4).
Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive
......................................................................
IMPALA-7060: Restrict Impala to only support timezones that work in Hive
IANA timezone integration (IMPALA-3307) will drop the support for
many non-standard timezone aliases. As IMPALA-3307 is a very large
change, its release may be delayed - meanwhile, it would be better
to discourage Impala 3.x users from using timezone names that will
not be supported in the future. For this reason, this change drops
the support of non-standard aliases from the current boost based
implementation.
This is supposed to be a temporary solution till IMPALA-3307, so
I have put minimal effort into it.
Testing:
- a few timezones are removed from timezoneverification.csv
- added test for invalid timezone names
Cherry-picks: not for 2.x.
Change-Id: I90859398081bae4976af31b09b3121c198b6adac
---
M be/src/exprs/timestamp-functions.cc
M be/src/exprs/timezone_db.cc
M testdata/data/timezoneverification.csv
M tests/query_test/test_timezones.py
4 files changed, 17 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/10486/4
--
To view, visit http://gerrit.cloudera.org:8080/10486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90859398081bae4976af31b09b3121c198b6adac
Gerrit-Change-Number: 10486
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>