You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/16 16:02:40 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
susiwen8 opened a new pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix legend scroll animation always start at first element, even the page number wasn't 1.
The problem was that legend content group always reset position to first element before animation.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
### After: How is it fixed in this PR?
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-710744917
Clearly `contentPos` has some reason to be there, I look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-710763609
@100pah Can you explain the purpose of `contentPos`. Obviously, the current animation is not correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-711044422
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-710142719
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #13443: Fix(legend.scroll): scroll animation start position was incorrect
Posted by GitBox <gi...@apache.org>.
100pah commented on pull request #13443:
URL: https://github.com/apache/incubator-echarts/pull/13443#issuecomment-711044389
@pissang @susiwen8
This animation is correct in 4.9.
But there is a mistake when refactor it from `position` to `xy` in 5.0.
The reason of `contentPos`:
in case that the elements inside `contentGroup` are layout not based on `[0, 0]`. (for example, the left-top displayable part is at `[-0.5, -0.5]`)
In most cases that will not happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org